styleguide/c++/c++11.html - Issue 2161193003: Use __func__ instead of __FUNCTION__.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: styleguide/c++/c++11.html

Issue 2161193003: Use __func__ instead of __FUNCTION__. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resync Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/url_request/url_request_job.cc ('k') | third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: styleguide/c++/c++11.html

diff --git a/styleguide/c++/c++11.html b/styleguide/c++/c++11.html

index 123ecd8651ef92be7ba36289e6a8036ed026f0f4..f13d8a62dc78236df02eb9cb14aa2a2ee7032c3a 100644

--- a/styleguide/c++/c++11.html

+++ b/styleguide/c++/c++11.html

@@ -75,6 +75,14 @@ with the language.

</tr>

<tr>

+<td>__func__ Local Variable</td>

+<td><code>__func__</code></td>

+<td>Provides a local variable containing the name of the enclosing function</td>

+<td><a href="https://msdn.microsoft.com/en-us/library/dn919276.aspx">__func__</a></td>

+<td>Use instead of the non-standard <code>__FUNCTION__</code>. <a href="https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/ojGfcgSDzHM">Discussion thread</a></td>

+</tr>

+<tr>

<td>Aliases</td>

<td><code>using new_alias = typename</code></td>

<td>Allow parameterized typedefs</td>

@@ -510,14 +518,6 @@ codebase.

</tr>

<tr>

-<td>Function Local Variable</td>

-<td><code>__func__</code></td>

-<td>Provides a local variable of the name of the enclosing function for logging purposes</td>

-<td><a href="http://www.informit.com/guides/content.aspx?g=cplusplus&seqNum=338">The __func__ Predeclared Identifier is Coming to C++</a></td>

-<td>Reevaluate now that MSVS2015 is available. <a href="https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/ojGfcgSDzHM">Discussion thread</a></td>

-</tr>

-<tr>

<td>Inherited Constructors</td>

<td><code>class Derived : Base {

using Base::Base;