content/browser/download/save_file_manager.cc - Issue 2161193003: Use __func__ instead of __FUNCTION__.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/save_file_manager.cc

Issue 2161193003: Use __func__ instead of __FUNCTION__. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resync Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/save_file_manager.cc

diff --git a/content/browser/download/save_file_manager.cc b/content/browser/download/save_file_manager.cc

index 527a7a18fbbb97f0a11f6618c461cecd538087fa..09e97b551484c8fea77b2777a5e915e4fa709b8f 100644

--- a/content/browser/download/save_file_manager.cc

+++ b/content/browser/download/save_file_manager.cc

@@ -200,8 +200,7 @@ void SaveFileManager::UpdateSaveProgress(SaveItemId save_item_id,

void SaveFileManager::SaveFinished(SaveItemId save_item_id,

SavePackageId save_package_id,

bool is_success) {

- DVLOG(20) << " " << __FUNCTION__ << "()"

- << " save_item_id = " << save_item_id

+ DVLOG(20) << __func__ << "() save_item_id = " << save_item_id

<< " save_package_id = " << save_package_id

<< " is_success = " << is_success;

DCHECK_CURRENTLY_ON(BrowserThread::FILE);

@@ -210,8 +209,7 @@ void SaveFileManager::SaveFinished(SaveItemId save_item_id,

SaveFile* save_file = LookupSaveFile(save_item_id);

if (save_file != nullptr) {

DCHECK(save_file->InProgress());

- DVLOG(20) << " " << __FUNCTION__ << "()"

- << " save_file = " << save_file->DebugString();

+ DVLOG(20) << __func__ << "() save_file = " << save_file->DebugString();

bytes_so_far = save_file->BytesSoFar();

save_file->Finish();

save_file->Detach();