Chromium Code Reviews| Index: chrome/installer/util/delete_after_reboot_helper.cc |
| diff --git a/chrome/installer/util/delete_after_reboot_helper.cc b/chrome/installer/util/delete_after_reboot_helper.cc |
| index c9cf0fe783f56796ee07eccf46067eed48f2697c..59f4508d9557e2a76c152ec9536df24a92b7e184 100644 |
| --- a/chrome/installer/util/delete_after_reboot_helper.cc |
| +++ b/chrome/installer/util/delete_after_reboot_helper.cc |
| @@ -252,7 +252,7 @@ base::FilePath GetShortPathName(const base::FilePath& path) { |
| MAX_PATH); |
| DWORD last_error = ::GetLastError(); |
|
grt (UTC plus 2)
2016/07/20 06:18:51
while you're at it, could you remove this line and
Peter Kasting
2016/07/20 06:27:22
That last error value is used in the condition for
grt (UTC plus 2)
2016/07/20 06:32:47
Ah, I just saw "DLOG" and "gle" in the message wit
Peter Kasting
2016/07/20 06:35:51
I don't mind at all, it's more convenient than doi
|
| DLOG_IF(WARNING, length == 0 && last_error != ERROR_PATH_NOT_FOUND) |
| - << __FUNCTION__ << " gle=" << last_error; |
| + << __func__ << " gle=" << last_error; |
| if ((length == 0) || (length > MAX_PATH)) { |
| // GetShortPathName fails if the path is no longer present or cannot be |
| // put in the size buffer provided. Instead of returning an empty string, |