Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4363)

Unified Diff: build/config/android/config.gni

Issue 2161183003: Build libmonochrome.so with secondary toolchain (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/android/config.gni
diff --git a/build/config/android/config.gni b/build/config/android/config.gni
index 24852d555dd061c2b5f145b352fbc933aea0a8ad..993050254339d296e5126cb2b1525f8491eb51aa 100644
--- a/build/config/android/config.gni
+++ b/build/config/android/config.gni
@@ -4,6 +4,8 @@
# This file contains common system config stuff for the Android build.
+import("//build/config/android/secondary_abi.gni")
agrieve 2016/07/20 02:11:03 Having this as a separate file doesn't really make
michaelbai 2016/07/20 16:51:10 It was used in more than one place, moved into thi
+
if (is_android) {
assert(rebase_path("//", root_build_dir) == "../../",
"Android output directory must be nested 2 levels within src/ (" +
@@ -266,11 +268,10 @@ if (is_android) {
# ABI ------------------------------------------------------------------------
- # Intentionally do not define android_app_secondary_abi for 64-bit
+ # Intentionally do not define android_app_secondary_abi for 32-bit
# android_app_abi, since they are not used.
if (current_cpu == "x86") {
android_app_abi = "x86"
- android_app_secondary_abi = "x86_64"
} else if (current_cpu == "arm") {
import("//build/config/arm.gni")
if (arm_version < 7) {
@@ -278,16 +279,17 @@ if (is_android) {
} else {
android_app_abi = "armeabi-v7a"
}
- android_app_secondary_abi = "arm64-v8a"
} else if (current_cpu == "mipsel") {
android_app_abi = "mips"
- android_app_secondary_abi = "mips64"
} else if (current_cpu == "x64") {
android_app_abi = "x86_64"
+ android_app_secondary_abi = "x86"
agrieve 2016/07/20 02:11:03 If we're going to have a separate file for seconda
} else if (current_cpu == "arm64") {
android_app_abi = "arm64-v8a"
+ android_app_secondary_abi = "armeabi-v7a"
} else if (current_cpu == "mips64el") {
android_app_abi = "mips64"
+ android_app_secondary_abi = "mips"
} else {
assert(false, "Unknown Android ABI: " + current_cpu)
}

Powered by Google App Engine
This is Rietveld 408576698