add aria-labelledby to options device sliders

add aria-labelledby to options device sliders

Not doing so yields accessibility errors in browser tests when a
mouse or touchpad are present (as they will be once enabling fake
pointers in crrev.com/2006083002)

R=stevenjb@chromium.org
BUG=612986
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e6d83603c47a932ea7d4822dd65442456ee26280
Cr-Commit-Position: refs/heads/master@{#406365}

[michaelpg, 2016-07-19 18:07:40]

Description was changed from

==========
add aria-labelledby to options device sliders

Not doing so yields accessibility errors in browser tests when a
mouse or touchpad are present (as they will be once enabling fake
pointers in crrev.com/2006083002)

R=stevenjb@chromium.org
BUG=612986
==========

to

==========
add aria-labelledby to options device sliders

Not doing so yields accessibility errors in browser tests when a
mouse or touchpad are present (as they will be once enabling fake
pointers in crrev.com/2006083002)

R=stevenjb@chromium.org
BUG=612986
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-07-19 18:08:07]

PTAL

[stevenjb, 2016-07-19 18:52:11]

This pattern may be worth componentizing, but for now, thanks, lgtm.

[michaelpg, 2016-07-19 19:09:30]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-07-19 19:09:57]

On 2016/07/19 18:52:11, stevenjb wrote:
> This pattern may be worth componentizing, but for now, thanks, lgtm.

This will soon be deleted code :-)

It remains to be seen how this will work in Polymer...

[commit-bot: I haz the power, 2016-07-19 19:10:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stevenjb, 2016-07-19 19:59:42]

Oh, right, "options"... sigh.


On Tue, Jul 19, 2016 at 1:09 PM, <michaelpg@chromium.org> wrote:

> On 2016/07/19 18:52:11, stevenjb wrote:
> > This pattern may be worth componentizing, but for now, thanks, lgtm.
>
> This will soon be deleted code :-)
>
> It remains to be seen how this will work in Polymer...
>
> https://codereview.chromium.org/2161183002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-07-19 20:17:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-19 20:19:13]

Description was changed from

==========
add aria-labelledby to options device sliders

Not doing so yields accessibility errors in browser tests when a
mouse or touchpad are present (as they will be once enabling fake
pointers in crrev.com/2006083002)

R=stevenjb@chromium.org
BUG=612986
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
add aria-labelledby to options device sliders

Not doing so yields accessibility errors in browser tests when a
mouse or touchpad are present (as they will be once enabling fake
pointers in crrev.com/2006083002)

R=stevenjb@chromium.org
BUG=612986
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e6d83603c47a932ea7d4822dd65442456ee26280
Cr-Commit-Position: refs/heads/master@{#406365}
==========

[commit-bot: I haz the power, 2016-07-19 20:19:14]

Patchset 1 (id:??) landed as
https://crrev.com/e6d83603c47a932ea7d4822dd65442456ee26280
Cr-Commit-Position: refs/heads/master@{#406365}