Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2161183002: add aria-labelledby to options device sliders (Closed)

Created:
4 years, 5 months ago by michaelpg
Modified:
4 years, 5 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add aria-labelledby to options device sliders Not doing so yields accessibility errors in browser tests when a mouse or touchpad are present (as they will be once enabling fake pointers in crrev.com/2006083002) R=stevenjb@chromium.org BUG=612986 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e6d83603c47a932ea7d4822dd65442456ee26280 Cr-Commit-Position: refs/heads/master@{#406365}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/resources/options/browser_options.html View 1 chunk +8 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
michaelpg
PTAL
4 years, 5 months ago (2016-07-19 18:08:07 UTC) #2
stevenjb
This pattern may be worth componentizing, but for now, thanks, lgtm.
4 years, 5 months ago (2016-07-19 18:52:11 UTC) #3
michaelpg
On 2016/07/19 18:52:11, stevenjb wrote: > This pattern may be worth componentizing, but for now, ...
4 years, 5 months ago (2016-07-19 19:09:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161183002/1
4 years, 5 months ago (2016-07-19 19:10:31 UTC) #6
stevenjb
Oh, right, "options"... sigh. On Tue, Jul 19, 2016 at 1:09 PM, <michaelpg@chromium.org> wrote: > ...
4 years, 5 months ago (2016-07-19 19:59:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 20:17:37 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 20:19:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6d83603c47a932ea7d4822dd65442456ee26280
Cr-Commit-Position: refs/heads/master@{#406365}

Powered by Google App Engine
This is Rietveld 408576698