Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Side by Side Diff: src/objects-inl.h

Issue 2161153002: [ic] Fix megamorphic stub cache probing on some platforms. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressing comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 5186 matching lines...) Expand 10 before | Expand all | Expand 10 after
5197 } 5197 }
5198 } 5198 }
5199 return constant_pool; 5199 return constant_pool;
5200 } 5200 }
5201 5201
5202 Code::Flags Code::ComputeFlags(Kind kind, ExtraICState extra_ic_state, 5202 Code::Flags Code::ComputeFlags(Kind kind, ExtraICState extra_ic_state,
5203 CacheHolderFlag holder) { 5203 CacheHolderFlag holder) {
5204 // TODO(ishell): remove ICStateField. 5204 // TODO(ishell): remove ICStateField.
5205 // Compute the bit mask. 5205 // Compute the bit mask.
5206 unsigned int bits = KindField::encode(kind) | 5206 unsigned int bits = KindField::encode(kind) |
5207 ICStateField::encode(MONOMORPHIC) |
5208 ExtraICStateField::encode(extra_ic_state) | 5207 ExtraICStateField::encode(extra_ic_state) |
5209 CacheHolderField::encode(holder); 5208 CacheHolderField::encode(holder);
5210 return static_cast<Flags>(bits); 5209 return static_cast<Flags>(bits);
5211 } 5210 }
5212 5211
5213 Code::Flags Code::ComputeHandlerFlags(Kind handler_kind, 5212 Code::Flags Code::ComputeHandlerFlags(Kind handler_kind,
5214 CacheHolderFlag holder) { 5213 CacheHolderFlag holder) {
5215 return ComputeFlags(Code::HANDLER, handler_kind, holder); 5214 return ComputeFlags(Code::HANDLER, handler_kind, holder);
5216 } 5215 }
5217 5216
(...skipping 2899 matching lines...) Expand 10 before | Expand all | Expand 10 after
8117 #undef WRITE_INT64_FIELD 8116 #undef WRITE_INT64_FIELD
8118 #undef READ_BYTE_FIELD 8117 #undef READ_BYTE_FIELD
8119 #undef WRITE_BYTE_FIELD 8118 #undef WRITE_BYTE_FIELD
8120 #undef NOBARRIER_READ_BYTE_FIELD 8119 #undef NOBARRIER_READ_BYTE_FIELD
8121 #undef NOBARRIER_WRITE_BYTE_FIELD 8120 #undef NOBARRIER_WRITE_BYTE_FIELD
8122 8121
8123 } // namespace internal 8122 } // namespace internal
8124 } // namespace v8 8123 } // namespace v8
8125 8124
8126 #endif // V8_OBJECTS_INL_H_ 8125 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698