Check the scheme of a RenderViewHost before assuming it contains an extension.

extensions/browser/process_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/process_manager.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
@@ skipping 16 matching lines @@
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_delegate.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/browser/web_contents_user_data.h"
 #include "content/public/common/renderer_preferences.h"
 #include "extensions/browser/extension_host.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/extensions_browser_client.h"
 #include "extensions/browser/view_type_utils.h"
+#include "extensions/common/constants.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_messages.h"
 #include "extensions/common/manifest_handlers/background_info.h"
 #include "extensions/common/manifest_handlers/incognito_info.h"
 #include "extensions/common/one_shot_event.h"
 #include "extensions/common/switches.h"
 
 using content::BrowserContext;
 using content::RenderViewHost;
 using content::SiteInstance;
 using content::WebContents;
 
 namespace extensions {
 class RenderViewHostDestructionObserver;
 }
 DEFINE_WEB_CONTENTS_USER_DATA_KEY(
     extensions::RenderViewHostDestructionObserver);
 
 namespace extensions {
 
 namespace {
 
 std::string GetExtensionID(RenderViewHost* render_view_host) {
   // This works for both apps and extensions because the site has been
-  // normalized to the extension URL for apps.
-  if (!render_view_host->GetSiteInstance())
+  // normalized to the extension URL for hosted apps.
+  content::SiteInstance* site_instance = render_view_host->GetSiteInstance();
+  if (!site_instance)
     return std::string();
 
-  return render_view_host->GetSiteInstance()->GetSiteURL().host();
+  if (site_instance->GetSiteURL().scheme() != kExtensionScheme)

[ncarter (slow), 2014/03/28 19:25:31]

Comments in GURL seem to suggest that .SchemeIs(kExtensionScheme) would be the
preferred idiom.

[Jeffrey Yasskin, 2014/03/28 20:19:36]

Indeed, it's much better. Thanks.

+    return std::string();
+
+  return site_instance->GetSiteURL().host();
 }
 
 std::string GetExtensionIDFromFrame(
     content::RenderFrameHost* render_frame_host) {
   // This works for both apps and extensions because the site has been
   // normalized to the extension URL for apps.
   if (!render_frame_host->GetSiteInstance())
     return std::string();
 
   return render_frame_host->GetSiteInstance()->GetSiteURL().host();
@@ skipping 833 matching lines @@
     const Extension* extension =
         registry->enabled_extensions().GetExtensionOrAppByURL(url);
     if (extension && !IncognitoInfo::IsSplitMode(extension)) {
       return original_manager_->GetSiteInstanceForURL(url);
     }
   }
   return ProcessManager::GetSiteInstanceForURL(url);
 }
 
 }  // namespace extensions