Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 216113005: Revert of ARM Skia NEON patches - 35 - First AArch64 support (Closed)

Created:
6 years, 9 months ago by mtklein
Modified:
6 years, 9 months ago
CC:
skia-review_googlegroups.com, rmcilroy
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of ARM Skia NEON patches - 35 - First AArch64 support (https://codereview.chromium.org/143423004/) Reason for revert: GYP's failing on most (all?) bots. Original issue's description: > ARM Skia NEON patches - 35 - First AArch64 support > > Aarch64 support > > This change contains the necessary modifications to have Skia build and > run properly on an ARMv8 processor in aarch64 execution state. > > Here's a list of the changes: > > - add an arm64 target to the build system + SK_CPU_ARM64 flag > > - MatrixTest was failing when built in Release mode. Fused MAC > instructions were generated which made some intermediate results > more accurate. As the test relies on result comparison, the more > precise results when compared to others led to a gap bigger than > what was tolerated. As I don't know if some actual skia code relies > on results being comparable, I've disabled fused MAC instruction > with -ffp-contract=off for arm64. > > - Modify include/core/SkOnce.h to have barriers work. > > - SK_CPU_ARM64 implies SK_ARM_NEON_MODE_ALWAYS. > > - use existing Xfermode optimisations with modifications that can be > removed in the future when toolchains are ready. Also save a few > instructions is two Xfermodes (will apply to ARM too). > > - use existing SkBoxBlur and SkMorphology optimisations. > > - use existing SkBlitMask optimisations > > - use existing BitmapProcState and Convolution optimisations. > > Future changes will include: > > - Blitters (only partialy merged upstream) > > - SkUtils (there's little value in sending asm optimisations without > having them benchmarked on real hardware). > > Signed-off-by: Kevin PETIT <kevin.petit@arm.com>; > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=13980 TBR=djsollen@google.com,reed@google.com,halcanary@google.com,kevin.petit@arm.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13983

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -110 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/common_variables.gypi View 1 chunk +1 line, -1 line 0 comments Download
M gyp/opts.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
M include/core/SkOnce.h View 1 chunk +5 lines, -3 lines 0 comments Download
M include/core/SkPreConfig.h View 1 chunk +0 lines, -4 lines 0 comments Download
M platform_tools/barelinux/bin/arm64_make View 2 chunks +7 lines, -2 lines 0 comments Download
M src/core/SkUtilsArm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/opts/SkBitmapProcState_opts_arm.cpp View 5 chunks +4 lines, -4 lines 0 comments Download
M src/opts/SkXfermode_opts_arm_neon.cpp View 15 chunks +4 lines, -72 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of ARM Skia NEON patches - 35 - First AArch64 support
6 years, 9 months ago (2014-03-28 18:05:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/216113005/1
6 years, 9 months ago (2014-03-28 18:05:20 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 18:05:41 UTC) #3
Message was sent while issue was closed.
Change committed as 13983

Powered by Google App Engine
This is Rietveld 408576698