Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Issue 216113003: Oilpan: Replace all remaining adoptRef()s in the Event hierarchy with adoptRefWillBeRefCountedGarba… (Closed)

Created:
6 years, 9 months ago by haraken
Modified:
6 years, 9 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, dino_apple.com, pdr., Eric Willigers
Visibility:
Public.

Description

Oilpan: Replace all remaining adoptRef()s in the Event hierarchy with adoptRefWillBeRefCountedGarbageCollected() This CL just fixes left-over from r170164. BUG=340522 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170297

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M Source/core/svg/animation/SVGSMILElement.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionEvent.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionEvent.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
haraken
Sorry for iterative fixes. I believe this fixes all left-overs from r170164. PTAL.
6 years, 9 months ago (2014-03-28 07:14:45 UTC) #1
Mads Ager (chromium)
LGTM :)
6 years, 9 months ago (2014-03-28 07:18:18 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-28 07:33:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/216113003/20001
6 years, 9 months ago (2014-03-28 07:33:46 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 08:12:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-28 08:12:25 UTC) #6
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-28 08:30:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/216113003/20001
6 years, 9 months ago (2014-03-28 08:30:34 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 08:30:52 UTC) #9
Message was sent while issue was closed.
Change committed as 170297

Powered by Google App Engine
This is Rietveld 408576698