Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2161113004:
Revert of Switch cc::RollingTimeDeltaHistory to use a vector (Closed)
|
Created:
4 years, 5 months ago by chongjiang Modified:
4 years, 4 months ago CC:
chromium-reviews, cc-bugs_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert of Switch cc::RollingTimeDeltaHistory to use a vector (patchset #2 id:40001 of https://codereview.chromium.org/2127003002/ )
Reason for revert:
Performance regression: https://bugs.chromium.org/p/chromium/issues/detail?id=629349
Original issue's description:
> Switch cc::RollingTimeDeltaHistory to use a vector
>
> BUG=625351
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/9d71ccf7550bfaed0cd64cd168b55471fdfc8330
> Cr-Commit-Position: refs/heads/master@{#404899}
TBR=dhsharp@chromium.org,danakj@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=625351
Committed: https://crrev.com/6da29e4e93597849c947a0d998f1ff672993cdb0
Cr-Commit-Position: refs/heads/master@{#409412}
Patch Set 1 #
Messages
Total messages: 27 (13 generated)
The CQ bit was checked by chongjiang@chromium.org
Created Revert of Switch cc::RollingTimeDeltaHistory to use a vector
Description was changed from ========== Revert of Switch cc::RollingTimeDeltaHistory to use a vector (patchset #2 id:40001 of https://codereview.chromium.org/2127003002/ ) Reason for revert: Performance regression: https://bugs.chromium.org/p/chromium/issues/detail?id=629349 Original issue's description: > Switch cc::RollingTimeDeltaHistory to use a vector > > BUG=625351 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/9d71ccf7550bfaed0cd64cd168b55471fdfc8330 > Cr-Commit-Position: refs/heads/master@{#404899} TBR=dhsharp@chromium.org,danakj@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=625351 ========== to ========== Revert of Switch cc::RollingTimeDeltaHistory to use a vector (patchset #2 id:40001 of https://codereview.chromium.org/2127003002/ ) Reason for revert: Performance regression: https://bugs.chromium.org/p/chromium/issues/detail?id=629349 Original issue's description: > Switch cc::RollingTimeDeltaHistory to use a vector > > BUG=625351 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/9d71ccf7550bfaed0cd64cd168b55471fdfc8330 > Cr-Commit-Position: refs/heads/master@{#404899} TBR=dhsharp@chromium.org,danakj@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=625351 ==========
chongjiang@chromium.org changed reviewers: + sque@chromium.org - dhsharp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was unchecked by chongjiang@chromium.org
lgtm
The CQ bit was checked by chongjiang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
chongjiang@chromium.org changed required reviewers: + danakj@chromium.org
chongjiang@chromium.org changed reviewers: + mark@chromium.org, thakis@chromium.org
chongjiang@chromium.org changed required reviewers: - danakj@chromium.org
Adding more cc/base owners as reviewers, as danakj is OOO
You can TBR reverts.
LGTM anyway
The CQ bit was checked by chongjiang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Revert of Switch cc::RollingTimeDeltaHistory to use a vector (patchset #2 id:40001 of https://codereview.chromium.org/2127003002/ ) Reason for revert: Performance regression: https://bugs.chromium.org/p/chromium/issues/detail?id=629349 Original issue's description: > Switch cc::RollingTimeDeltaHistory to use a vector > > BUG=625351 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/9d71ccf7550bfaed0cd64cd168b55471fdfc8330 > Cr-Commit-Position: refs/heads/master@{#404899} TBR=dhsharp@chromium.org,danakj@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=625351 ========== to ========== Revert of Switch cc::RollingTimeDeltaHistory to use a vector (patchset #2 id:40001 of https://codereview.chromium.org/2127003002/ ) Reason for revert: Performance regression: https://bugs.chromium.org/p/chromium/issues/detail?id=629349 Original issue's description: > Switch cc::RollingTimeDeltaHistory to use a vector > > BUG=625351 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/9d71ccf7550bfaed0cd64cd168b55471fdfc8330 > Cr-Commit-Position: refs/heads/master@{#404899} TBR=dhsharp@chromium.org,danakj@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=625351 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Revert of Switch cc::RollingTimeDeltaHistory to use a vector (patchset #2 id:40001 of https://codereview.chromium.org/2127003002/ ) Reason for revert: Performance regression: https://bugs.chromium.org/p/chromium/issues/detail?id=629349 Original issue's description: > Switch cc::RollingTimeDeltaHistory to use a vector > > BUG=625351 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/9d71ccf7550bfaed0cd64cd168b55471fdfc8330 > Cr-Commit-Position: refs/heads/master@{#404899} TBR=dhsharp@chromium.org,danakj@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=625351 ========== to ========== Revert of Switch cc::RollingTimeDeltaHistory to use a vector (patchset #2 id:40001 of https://codereview.chromium.org/2127003002/ ) Reason for revert: Performance regression: https://bugs.chromium.org/p/chromium/issues/detail?id=629349 Original issue's description: > Switch cc::RollingTimeDeltaHistory to use a vector > > BUG=625351 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/9d71ccf7550bfaed0cd64cd168b55471fdfc8330 > Cr-Commit-Position: refs/heads/master@{#404899} TBR=dhsharp@chromium.org,danakj@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=625351 Committed: https://crrev.com/6da29e4e93597849c947a0d998f1ff672993cdb0 Cr-Commit-Position: refs/heads/master@{#409412} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6da29e4e93597849c947a0d998f1ff672993cdb0 Cr-Commit-Position: refs/heads/master@{#409412} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
