Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 2161073004: [arc-intents] Remove SSP matching; add unit tests. (Closed)

Created:
4 years, 5 months ago by Ben Kwa
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[arc-intents] Remove SSP matching; add unit tests. - As discussed with elijahtaylor@ and yusukes@, don't attempt matching for scheme-specific parts. Extracting an SSP from a chrome URL is fraught, and SSPs don't really apply to http/https URLs anyway. - Add unit tests for the IntentFilter class. BUG=628788 Review-Url: https://codereview.chromium.org/2156683002 Cr-Commit-Position: refs/heads/master@{#406283} (cherry picked from commit 5acc3b7599948290a46f7f9003e7a1cc5b466590) Committed: https://chromium.googlesource.com/chromium/src/+/0aac6daf43069ac480e64e153e742de28d0b2843

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -29 lines) Patch
M components/arc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/arc/common/intent_helper.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/intent_helper/intent_filter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/arc/intent_helper/intent_filter.cc View 5 chunks +4 lines, -26 lines 0 comments Download
A components/arc/intent_helper/intent_filter_unittest.cc View 1 chunk +321 lines, -0 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Ben Kwa
4 years, 5 months ago (2016-07-20 18:55:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0aac6daf43069ac480e64e153e742de28d0b2843.

Powered by Google App Engine
This is Rietveld 408576698