Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2161073003: [Media Router] Replace route messaging API. (Closed)

Created:
4 years, 5 months ago by imcheng
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Media Router] Replace route messaging API. Remove old callback-based ListenForRouteMessages API and replace it with StartListeningForRouteMessages and OnRouteMessagesReceived. The rationale is return value based API doesn't work well for event pages; when the event page is suspended, the callback supplied by the old API is lost and cannot be restored when the extension wakes up. Switching to the listener model unblocks the work to reduce the nessesity of keeping the event page alive and should result in considerably simpler logic on the extension side. To maintain backwards compatibility with older extensions, a smaller adapter logic is introduced in media_router_bindings.js. Add missing WakeReason for StartListeningForRouteMessages. Also added OWNERs for the mojom file to comply with presubmit. BUG=625007 Review-Url: https://codereview.chromium.org/2111303003 Cr-Commit-Position: refs/heads/master@{#406083} (cherry picked from commit bf455be1850399b8b374809cfc2584e0611e1c77) Committed: https://chromium.googlesource.com/chromium/src/+/c872eeb60ada88d0ef235a464e147c4384fe266a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -182 lines) Patch
A + chrome/browser/media/router/mojo/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router.mojom View 3 chunks +18 lines, -12 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_impl.h View 5 chunks +8 lines, -16 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_impl.cc View 3 chunks +24 lines, -50 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc View 4 chunks +12 lines, -86 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_metrics.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_test.h View 1 chunk +2 lines, -3 lines 0 comments Download
M extensions/renderer/resources/media_router_bindings.js View 5 chunks +47 lines, -14 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
imcheng
4 years, 5 months ago (2016-07-19 21:28:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c872eeb60ada88d0ef235a464e147c4384fe266a.

Powered by Google App Engine
This is Rietveld 408576698