Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Unified Diff: build/android/gyp/write_build_config.py

Issue 2161063003: 🎫 Fail write_build_config.py if current_toolchain != default_toolchain (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: put back _java target removed from test() Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/android/internal_rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/write_build_config.py
diff --git a/build/android/gyp/write_build_config.py b/build/android/gyp/write_build_config.py
index 70bc6d08104a0a6e08165a6b5daa52ce3be97fcb..18d76348f0e353383c11070c89e65d4f0ee9dee9 100755
--- a/build/android/gyp/write_build_config.py
+++ b/build/android/gyp/write_build_config.py
@@ -279,11 +279,15 @@ def main(argv):
help='Path to the proguard .info output for this apk.')
parser.add_option('--has-alternative-locale-resource', action='store_true',
help='Whether there is alternative-locale-resource in direct deps')
+ parser.add_option('--fail',
+ help='GYP-list of error message lines to fail with.')
options, args = parser.parse_args(argv)
if args:
parser.error('No positional arguments should be given.')
+ if options.fail:
+ parser.error('\n'.join(build_utils.ParseGypList(options.fail)))
required_options_map = {
'java_binary': ['build_config', 'jar_path'],
« no previous file with comments | « no previous file | build/config/android/internal_rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698