Route Text Layout Change IPCs to the Active RenderWidgetHost

Route Text Layout Change IPCs to the Active RenderWidgetHost

Currently, the call to
RenderWidgetHostViewAura::ChangeTextDirectionAndLayoutAlignment is only
routed to the tab's RenderWidge; which happens regardless of the
currently active widget. This CL will modify the code so that this IME
call is always routed to the active widget obtained from
TextInputManager. The CL also adds a unit test.

BUG=578168, 602723
Committed: https://crrev.com/6ede0ad8427019a2ad3ee962b2b395e31f69ae26
Cr-Commit-Position: refs/heads/master@{#406764}

[EhsanK, 2016-07-19 16:01:57]

ekaramad@chromium.org changed reviewers:
+ creis@chromium.org, kenrb@chromium.org

[EhsanK, 2016-07-19 16:01:58]

Ken, Charlie, Could you please take a look. Thanks!

https://codereview.chromium.org/2161043002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
(right):

https://codereview.chromium.org/2161043002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:4326: //
This test verifies ui::TextInputClient::SetCompositionText.
The comment on top of the test class explains what these tests do so I believe
it suffices to only say the method we are testing here.

[kenrb, 2016-07-19 19:50:37]

lgtm

[Charlie Reis, 2016-07-20 23:03:06]

LGTM

[Charlie Reis, 2016-07-20 23:03:30]

Description was changed from

==========
Route Text Layout Change IPCs to the Active RenderWidgetHost

Currently, the call to
RenderWidgetHostViewAura::ChangeTextDirectionAndLayoutAlignment is only
routed to the tab's RenderWidge; which happens regardless of the
currently active widget. This CL will modify the code so that this IME
call is always routed to the active widget obtained from
TextInputManager. The CL also adds a unit test.

BUG=578168,602723
==========

to

==========
Route Text Layout Change IPCs to the Active RenderWidgetHost

Currently, the call to
RenderWidgetHostViewAura::ChangeTextDirectionAndLayoutAlignment is only
routed to the tab's RenderWidge; which happens regardless of the
currently active widget. This CL will modify the code so that this IME
call is always routed to the active widget obtained from
TextInputManager. The CL also adds a unit test.

BUG=578168,602723
==========

[EhsanK, 2016-07-21 03:26:12]

The CQ bit was checked by ekaramad@chromium.org

[EhsanK, 2016-07-21 03:26:12]

The patchset sent to the CQ was uploaded after l-g-t-m from kenrb@chromium.org
Link to the patchset: https://codereview.chromium.org/2161043002/#ps20001
(title: "Rebased")

[commit-bot: I haz the power, 2016-07-21 03:26:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 04:17:32]

Description was changed from

==========
Route Text Layout Change IPCs to the Active RenderWidgetHost

Currently, the call to
RenderWidgetHostViewAura::ChangeTextDirectionAndLayoutAlignment is only
routed to the tab's RenderWidge; which happens regardless of the
currently active widget. This CL will modify the code so that this IME
call is always routed to the active widget obtained from
TextInputManager. The CL also adds a unit test.

BUG=578168,602723
==========

to

==========
Route Text Layout Change IPCs to the Active RenderWidgetHost

Currently, the call to
RenderWidgetHostViewAura::ChangeTextDirectionAndLayoutAlignment is only
routed to the tab's RenderWidge; which happens regardless of the
currently active widget. This CL will modify the code so that this IME
call is always routed to the active widget obtained from
TextInputManager. The CL also adds a unit test.

BUG=578168,602723
==========

[commit-bot: I haz the power, 2016-07-21 04:17:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-21 04:19:30]

Description was changed from

==========
Route Text Layout Change IPCs to the Active RenderWidgetHost

Currently, the call to
RenderWidgetHostViewAura::ChangeTextDirectionAndLayoutAlignment is only
routed to the tab's RenderWidge; which happens regardless of the
currently active widget. This CL will modify the code so that this IME
call is always routed to the active widget obtained from
TextInputManager. The CL also adds a unit test.

BUG=578168,602723
==========

to

==========
Route Text Layout Change IPCs to the Active RenderWidgetHost

Currently, the call to
RenderWidgetHostViewAura::ChangeTextDirectionAndLayoutAlignment is only
routed to the tab's RenderWidge; which happens regardless of the
currently active widget. This CL will modify the code so that this IME
call is always routed to the active widget obtained from
TextInputManager. The CL also adds a unit test.

BUG=578168,602723

Committed: https://crrev.com/6ede0ad8427019a2ad3ee962b2b395e31f69ae26
Cr-Commit-Position: refs/heads/master@{#406764}
==========

[commit-bot: I haz the power, 2016-07-21 04:19:31]

Patchset 2 (id:??) landed as
https://crrev.com/6ede0ad8427019a2ad3ee962b2b395e31f69ae26
Cr-Commit-Position: refs/heads/master@{#406764}