Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 2161033005: DevTools: Fix presubmits failing on InspectorFrontendHostAPI (Closed)

Created:
4 years, 5 months ago by einbinder
Modified:
4 years, 5 months ago
Reviewers:
paulirish, lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Fix presubmits failing on InspectorFrontendHostAPI Committed: https://crrev.com/49e6fc04a03c3ab7d41c877ec818253d72c6b8f3 Cr-Commit-Position: refs/heads/master@{#406709}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix second assignment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHost.js View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
einbinder
Your patch broke presubmit checks, is this an acceptable fix?
4 years, 5 months ago (2016-07-20 21:34:52 UTC) #2
lushnikov
lgtm, works for me if works for Paul nit: let's either put "BUG=none" or remove ...
4 years, 5 months ago (2016-07-20 21:37:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161033005/20001
4 years, 5 months ago (2016-07-20 21:57:16 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-20 23:35:10 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/49e6fc04a03c3ab7d41c877ec818253d72c6b8f3 Cr-Commit-Position: refs/heads/master@{#406709}
4 years, 5 months ago (2016-07-20 23:36:37 UTC) #12
paulirish
4 years, 5 months ago (2016-07-21 00:24:07 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698