Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 2161033003: Create compiler-scheduler subdir and move existing scheduler there (Closed)

Created:
4 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer, marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Create compiler-scheduler subdir and move existing scheduler there BUG=v8:5215 R=marja@chromium.org Committed: https://crrev.com/04ba79eb72b48a09e635281f3ee3fac5031f620f Cr-Commit-Position: refs/heads/master@{#37906}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -349 lines) Patch
M BUILD.gn View 3 chunks +8 lines, -4 lines 0 comments Download
A + src/compiler-dispatcher/optimizing-compile-dispatcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + src/compiler-dispatcher/optimizing-compile-dispatcher.cc View 9 chunks +1 line, -9 lines 0 comments Download
M src/isolate.h View 2 chunks +1 line, -1 line 0 comments Download
D src/optimizing-compile-dispatcher.h View 1 chunk +0 lines, -102 lines 0 comments Download
D src/optimizing-compile-dispatcher.cc View 1 chunk +0 lines, -228 lines 0 comments Download
M src/v8.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
jochen (gone - plz use gerrit)
4 years, 5 months ago (2016-07-20 11:53:49 UTC) #1
marja
- don't you want OWNERS for the subdir? - lgtm as this is just manual
4 years, 5 months ago (2016-07-20 11:55:33 UTC) #4
jochen (gone - plz use gerrit)
dunno, who would be an owner?
4 years, 5 months ago (2016-07-20 11:56:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161033003/1
4 years, 5 months ago (2016-07-20 11:56:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 12:53:39 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 12:53:41 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/04ba79eb72b48a09e635281f3ee3fac5031f620f Cr-Commit-Position: refs/heads/master@{#37906}
4 years, 5 months ago (2016-07-20 12:56:09 UTC) #12
Benedikt Meurer
4 years, 5 months ago (2016-07-20 17:29:44 UTC) #14
Message was sent while issue was closed.
Nit: Can we please, please stop using the name "scheduler" in combination with
"compiler" for anything else than the actual scheduler in the compiler. This is
highly confusing, since there's already a core compiler component that's called
"scheduler", plus a second one, which is the InstructionScheduler (and no I
don't care who was first, just use "dispatcher" for that other thing, as you
already did in the directory).

Powered by Google App Engine
This is Rietveld 408576698