Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Side by Side Diff: gm/rebaseline_server/compare_rendered_pictures_test.py

Issue 216103004: teach rebaseline_server how to compare results of multiple render_pictures runs (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: ravi comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gm/rebaseline_server/compare_rendered_pictures.py ('k') | gm/rebaseline_server/results.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 2
3 """ 3 """
4 Copyright 2014 Google Inc. 4 Copyright 2014 Google Inc.
5 5
6 Use of this source code is governed by a BSD-style license that can be 6 Use of this source code is governed by a BSD-style license that can be
7 found in the LICENSE file. 7 found in the LICENSE file.
8 8
9 Test compare_configs.py 9 Test compare_rendered_pictures.py
10 10
11 TODO(epoger): Create a command to update the expected results (in 11 TODO(epoger): Create a command to update the expected results (in
12 self._output_dir_expected) when appropriate. For now, you should: 12 self._output_dir_expected) when appropriate. For now, you should:
13 1. examine the results in self._output_dir_actual and make sure they are ok 13 1. examine the results in self._output_dir_actual and make sure they are ok
14 2. rm -rf self._output_dir_expected 14 2. rm -rf self._output_dir_expected
15 3. mv self._output_dir_actual self._output_dir_expected 15 3. mv self._output_dir_actual self._output_dir_expected
16 Although, if you're using an SVN checkout, this will blow away .svn directories 16 Although, if you're using an SVN checkout, this will blow away .svn directories
17 within self._output_dir_expected, which wouldn't be good... 17 within self._output_dir_expected, which wouldn't be good...
18 18
19 """ 19 """
20 20
21 import os 21 import os
22 import sys 22 import sys
23 23
24 # Imports from within Skia 24 # Imports from within Skia
25 import base_unittest 25 import base_unittest
26 import compare_configs 26 import compare_rendered_pictures
27 import results 27 import results
28 import gm_json # must import results first, so that gm_json will be in sys.path 28 import gm_json # must import results first, so that gm_json will be in sys.path
29 29
30 30
31 class CompareConfigsTest(base_unittest.TestCase): 31 class CompareRenderedPicturesTest(base_unittest.TestCase):
32 32
33 def test_gm(self): 33 def test_endToEnd(self):
34 """Process results of a GM run with the ConfigComparisons object.""" 34 """Compare results of two render_pictures runs."""
35 results_obj = compare_configs.ConfigComparisons( 35 # TODO(epoger): Specify image_base_url pointing at the directory on local
epoger 2014/04/04 15:31:53 Added a TODO here, after noticing that the unittes
36 configs=('8888', 'gpu'), 36 # disk containing our test images, so that we can actually compute pixel
37 actuals_root=os.path.join(self._input_dir, 'gm-actuals'), 37 # diffs. For now, this test attempts to download images from
38 # DEFAULT_IMAGE_BASE_URL, and there aren't any there yet.
39 results_obj = compare_rendered_pictures.RenderedPicturesComparisons(
40 actuals_root=os.path.join(self._input_dir, 'render_pictures_output'),
41 subdirs=('before_patch', 'after_patch'),
38 generated_images_root=self._temp_dir, 42 generated_images_root=self._temp_dir,
39 diff_base_url='/static/generated-images') 43 diff_base_url='/static/generated-images')
40 results_obj.get_timestamp = mock_get_timestamp 44 results_obj.get_timestamp = mock_get_timestamp
41 gm_json.WriteToFile( 45 gm_json.WriteToFile(
42 results_obj.get_packaged_results_of_type( 46 results_obj.get_packaged_results_of_type(
43 results.KEY__HEADER__RESULTS_ALL), 47 results.KEY__HEADER__RESULTS_ALL),
44 os.path.join(self._output_dir_actual, 'gm.json')) 48 os.path.join(self._output_dir_actual, 'compare_rendered_pictures.json'))
45 49
46 50
47 def mock_get_timestamp(): 51 def mock_get_timestamp():
48 """Mock version of BaseComparisons.get_timestamp() for testing.""" 52 """Mock version of BaseComparisons.get_timestamp() for testing."""
49 return 12345678 53 return 12345678
50 54
51 55
52 def main(): 56 def main():
53 base_unittest.main(CompareConfigsTest) 57 base_unittest.main(CompareRenderedPicturesTest)
54 58
55 59
56 if __name__ == '__main__': 60 if __name__ == '__main__':
57 main() 61 main()
OLDNEW
« no previous file with comments | « gm/rebaseline_server/compare_rendered_pictures.py ('k') | gm/rebaseline_server/results.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698