Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2161013005: Revert of Add missing dependency to components_unittests GYP build (Closed)

Created:
4 years, 5 months ago by engedy
Modified:
4 years, 5 months ago
CC:
chromium-reviews, llozano
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add missing dependency to components_unittests GYP build (patchset #1 id:1 of https://codereview.chromium.org/2160303004/ ) Reason for revert: This was a follow-up for https://codereview.chromium.org/2064463002/, which has been reverted in the meantime in https://codereview.chromium.org/2166553003/, and now this second CL by its lonesome is causing compile error on "Linux Chromium OS ASan LSan Builder". Original issue's description: > Add missing dependency to components_unittests GYP build > > It should have been added in http://crrev.com/2064463002 > > BUG=chromium:615223 > TEST=build components_unittests with GYP, components_unittests passes > TBR=hayato@chromium.org, wfh@chromium.org > NOTRY=true > NOTREECHECKS=true > > Committed: https://crrev.com/d149b80d547b9766d90159f80e931005acf1b433 > Cr-Commit-Position: refs/heads/master@{#406478} TBR=hayato@chromium.org,llozano@google.com,wfh@chromium.org,sque@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:615223 Committed: https://crrev.com/fb7824ff79e38d1de021d41c65474e6ff0cb8153 Cr-Commit-Position: refs/heads/master@{#406525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
engedy
Created Revert of Add missing dependency to components_unittests GYP build
4 years, 5 months ago (2016-07-20 12:26:39 UTC) #2
engedy
Tracked in: crbug.com/629760. Compile fails with: gyp: Dependency '/mnt/data/b/c/b/Linux_Chromium_OS_ASan_LSan_Builder/src/components/components.gyp:metrics_mojo_bindings#target' not found while trying to load ...
4 years, 5 months ago (2016-07-20 12:27:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161013005/1
4 years, 5 months ago (2016-07-20 12:27:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 12:28:13 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 12:28:22 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 12:30:11 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb7824ff79e38d1de021d41c65474e6ff0cb8153
Cr-Commit-Position: refs/heads/master@{#406525}

Powered by Google App Engine
This is Rietveld 408576698