Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2161013002: [turbofan] Fix typing rule for number addition. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix typing rule for number addition. R=jarin@chromium.org BUG=chromium:629435 Committed: https://crrev.com/e0b8707c78b337167d6ba7c42a332be2b6f82d92 Cr-Commit-Position: refs/heads/master@{#37859}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M src/compiler/operation-typer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-629435.js View 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-19 09:17:03 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the fix for the Invoke crasher. Please take a look. Thanks, Benedikt
4 years, 5 months ago (2016-07-19 09:17:34 UTC) #4
Jarin
lgtm
4 years, 5 months ago (2016-07-19 09:20:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161013002/1
4 years, 5 months ago (2016-07-19 09:33:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 10:08:04 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 10:08:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0b8707c78b337167d6ba7c42a332be2b6f82d92
Cr-Commit-Position: refs/heads/master@{#37859}

Powered by Google App Engine
This is Rietveld 408576698