Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-repeat-get-set.html

Issue 2161003003: [css-grid] repeat() syntax should take a <track-list> argument (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-repeat-get-set.html
diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-repeat-get-set.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-repeat-get-set.html
index 8f0fb4d138b547160bcb076ddcae3d2e73583616..ba0ee17701a3301c8c0c757330d8027fc6371e71 100644
--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-repeat-get-set.html
+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-repeat-get-set.html
@@ -68,6 +68,12 @@
grid-template-rows: repeat(2, 10px) [end] auto;
grid-template-columns: repeat(2, 250px) 15% [last];
}
+
+.multipleTrackRepeat {
+ grid-template-rows: repeat(3, min-content [a] max-content [b c] 20px [d]) [e] 1em;
+ grid-template-columns: [start] 20px repeat(2, [a] minmax(20px, min-content) max-content [b]) 200px [c] min-content [end];
+}
+
</style>
<script src="../../resources/js-test.js"></script>
</head>
@@ -94,6 +100,7 @@
<div class="gridItem"></div>
</div>
<div class="grid definite mixNonRepeatAfterRepeat alignContentStart" id="mixNonRepeatAfterRepeat"></div>
+<div class="grid multipleTrackRepeat" id="multipleTrackRepeat"></div>
<script src="resources/grid-definitions-parsing-utils.js"></script>
<script>
@@ -111,6 +118,7 @@
testGridDefinitionsValues(document.getElementById("leadingNamedGridLineRepeat"), "[start] 250px 250px", "[start] 10px 10px");
testGridDefinitionsValues(document.getElementById("mixRepeatAfterNonRepeat"), "[start] 140px 250px 250px", "44px 10px 10px");
testGridDefinitionsValues(document.getElementById("mixNonRepeatAfterRepeat"), "250px 250px 120px [last]", "10px 10px [end] 0px");
+ testGridDefinitionsValues(document.getElementById("multipleTrackRepeat"), "[start] 20px [a] 20px 0px [b a] 20px 0px [b] 200px [c] 0px [end]", "0px [a] 0px [b c] 20px [d] 0px [a] 0px [b c] 20px [d] 0px [a] 0px [b c] 20px [d e] 16px");
debug("");
debug("Test invalid repeat syntax.");
@@ -130,8 +138,10 @@
testInvalidSyntax("repeat(1, [foo])");
testInvalidSyntax("repeat(1, )");
testInvalidSyntax("repeat(1)");
+ testInvalidSyntax("repeat(3, [a] [a] 100px 200px)");
// Nesting is no allowed.
testInvalidSyntax("repeat(2, repeat(1, auto))");
+ testInvalidSyntax("repeat(2, [a] 100px 200px repeat(2, 20px))");
</script>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698