third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp - Issue 2161003002: CustomElements: upgrade element patch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

Issue 2161003002: CustomElements: upgrade element patch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@upgrade-element

Patch Set: workflow commit Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

index 72245da7b33fedbfa0c30e88044881ded386ef5e..8d49ef1f4aefb85d88a4458027512fadf696f391 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

@@ -123,7 +123,8 @@ void CustomElementDefinition::upgrade(Element* element)

if (!succeeded)

return;

- CHECK(element->getCustomElementState() == CustomElementState::Custom);

+ element->setCustomElementState(CustomElementState::Custom);

+ // CHECK(element->getCustomElementState() == CustomElementState::Custom);

dominicc (has gone to gerrit) 2016/07/22 07:34:08 Delete this line.

}

bool CustomElementDefinition::hasAttributeChangedCallback(