third_party/WebKit/LayoutTests/custom-elements/spec/upgrade-element-expected.txt - Issue 2161003002: CustomElements: upgrade element patch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/custom-elements/spec/upgrade-element-expected.txt

Issue 2161003002: CustomElements: upgrade element patch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@upgrade-element

Patch Set: workflow commit Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/custom-elements/spec/upgrade-element.html ('K') | « third_party/WebKit/LayoutTests/custom-elements/spec/upgrade-element.html ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/custom-elements/spec/upgrade-element-expected.txt

diff --git a/third_party/WebKit/LayoutTests/custom-elements/spec/upgrade-element-expected.txt b/third_party/WebKit/LayoutTests/custom-elements/spec/upgrade-element-expected.txt

deleted file mode 100644

index a479d42fbdcec097e0736ac3a969d91d6a748b72..0000000000000000000000000000000000000000

--- a/third_party/WebKit/LayoutTests/custom-elements/spec/upgrade-element-expected.txt

+++ /dev/null

@@ -1,7 +0,0 @@

-This is a testharness.js-based test.

dominicc (has gone to gerrit) 2016/07/22 07:34:08 Yay.

-PASS "connectedCallback", "attributeChangedCallback" reactions should execute after the constructor

-PASS The constructor non-conformatly uses API decorated with the [CEReactions]

-FAIL Upgrading an element with a throwing constructor should rethrow that exception assert_array_equals: rethrow any exception thrown from constructor property 0, expected "constructor throws" but got object "Error: assert_false: calling super() with non-empty construction stack should not define the element expected false got true"

-FAIL Upgrading an element with invalid constructor assert_array_equals: returning object that is different from element should throw "InvalidStateError" lengths differ, expected 1 got 0

-Harness: the test ran to completion.