Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2160983004: Removing unused DRP histograms. (Closed)

Created:
4 years, 5 months ago by RyanSturm
Modified:
4 years, 5 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing unused DRP histograms. The following histograms are being marked as obsolete and the instrumentation is being removed: PLT.NT_Request*, PLT.NT_Redirect*, PLT.NT_Response*, PLT.NT_DelayBefore* BUG=629389, 629390 Committed: https://crrev.com/b74e7a4d8e957ffc4134a673f0e9ec291d746218 Cr-Commit-Position: refs/heads/master@{#406929}

Patch Set 1 #

Patch Set 2 : removing unused variables #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -52 lines) Patch
M chrome/renderer/page_load_histograms.cc View 1 2 chunks +0 lines, -52 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
RyanSturm
bengr: PTAL
4 years, 5 months ago (2016-07-19 22:02:52 UTC) #4
bengr
lgtm
4 years, 5 months ago (2016-07-21 00:07:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160983004/20001
4 years, 5 months ago (2016-07-21 16:40:38 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/222417)
4 years, 5 months ago (2016-07-21 16:48:32 UTC) #11
RyanSturm
asvitkine: PTAL
4 years, 5 months ago (2016-07-21 17:14:55 UTC) #13
Alexei Svitkine (slow)
LGTM thanks for the cleanup!
4 years, 5 months ago (2016-07-21 18:31:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160983004/20001
4 years, 5 months ago (2016-07-21 18:32:14 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/222557)
4 years, 5 months ago (2016-07-21 18:44:41 UTC) #18
RyanSturm
csharrison: PTAL @ page_load_histograms.cc, thanks
4 years, 5 months ago (2016-07-21 18:46:16 UTC) #20
Charlie Harrison
lgtm thank you.
4 years, 5 months ago (2016-07-21 19:03:04 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160983004/20001
4 years, 5 months ago (2016-07-21 19:05:26 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 19:13:09 UTC) #24
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 19:16:35 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b74e7a4d8e957ffc4134a673f0e9ec291d746218
Cr-Commit-Position: refs/heads/master@{#406929}

Powered by Google App Engine
This is Rietveld 408576698