Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 2160983003: [ContextMenu] Shift+F10 should trigger contextmenu on keydown to match system behavior (Closed)

Created:
4 years, 5 months ago by chongz
Modified:
4 years, 5 months ago
Reviewers:
bokan
CC:
chromium-reviews, blink-reviews, mlamouri+watch-blink_chromium.org, kinuko+watch, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Shift+F10 should trigger contextmenu on keydown to match system behavior On Windows native apps (e.g. Notepad) Shift+F10 will trigger contextmenu on keydown, we should match this system bahavior. Web exposed effect: JS will be able to prevent Shift+F10 contextmenu by preventing 'keydown'. (Used to be 'keyup') Interop: After CL we will match FF, IE, as well as Chrome on other platforms. BUG=405813 Committed: https://crrev.com/faa92be14a884079406b4354d5decdf3370eaa02 Cr-Commit-Position: refs/heads/master@{#406706}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/NeverFixTests View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/events/context-menu-key-shift-f10-prevent-default.html View 1 chunk +45 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
chongz
bokan@ this is another ContextMenu issue, PTAL, thanks!
4 years, 5 months ago (2016-07-20 17:19:02 UTC) #7
bokan
lgtm
4 years, 5 months ago (2016-07-20 19:18:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160983003/1
4 years, 5 months ago (2016-07-20 20:50:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 23:20:00 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 23:22:06 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/faa92be14a884079406b4354d5decdf3370eaa02
Cr-Commit-Position: refs/heads/master@{#406706}

Powered by Google App Engine
This is Rietveld 408576698