Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: media/base/media_log.h

Issue 2160963002: Add watch time metrics for HTML5 media playback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/media/media_internals.cc ('k') | media/base/media_log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/media_log.h
diff --git a/media/base/media_log.h b/media/base/media_log.h
index 64a3f3d4c86578fe5ade5070f883edeb27f7b955..cfcf05308925ca59373f6a8646e6394c609563c6 100644
--- a/media/base/media_log.h
+++ b/media/base/media_log.h
@@ -83,6 +83,18 @@ class MEDIA_EXPORT MediaLog : public base::RefCountedThreadSafe<MediaLog> {
void SetDoubleProperty(const std::string& key, double value);
void SetBooleanProperty(const std::string& key, bool value);
+ // Histogram names used for reporting; also double as MediaLog key names.
+ static const char kWatchTimeAudioVideoAll[];
+ static const char kWatchTimeAudioVideoMse[];
+ static const char kWatchTimeAudioVideoEme[];
+ static const char kWatchTimeAudioVideoSrc[];
+ static const char kWatchTimeAudioVideoBattery[];
+ static const char kWatchTimeAudioVideoAc[];
+
+ // Markers which signify the watch time should be finalized immediately.
+ static const char kWatchTimeFinalize[];
+ static const char kWatchTimeFinalizePower[];
+
protected:
friend class base::RefCountedThreadSafe<MediaLog>;
virtual ~MediaLog();
« no previous file with comments | « content/browser/media/media_internals.cc ('k') | media/base/media_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698