media/base/media_log.cc - Issue 2160963002: Add watch time metrics for HTML5 media playback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/media_log.cc

Issue 2160963002: Add watch time metrics for HTML5 media playback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Only log watch time once. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/media_log.cc

diff --git a/media/base/media_log.cc b/media/base/media_log.cc

index 546eb45026940fd01703e23dc0d277240538e7b7..fbc34f09924aa12fee712f5e4a5b3655abbcbfa8 100644

--- a/media/base/media_log.cc

+++ b/media/base/media_log.cc

@@ -82,6 +82,8 @@ std::string MediaLog::EventTypeToString(MediaLogEvent::Type type) {

return "MEDIA_DEBUG_LOG_ENTRY";

case MediaLogEvent::PROPERTY_CHANGE:

return "PROPERTY_CHANGE";

+ case MediaLogEvent::WATCH_TIME_UPDATE:

+ return "WATCH_TIME_UPDATE";

}

NOTREACHED();

return NULL;