Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2160953005: Add some tests related to type equality after reload. (Closed)

Created:
4 years, 5 months ago by rmacnak
Modified:
4 years, 5 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add some tests related to type equality after reload. BUG=http://dartbug.com/26869 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/8e7e84811245379f305f3e287caded936b30ddd5

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -0 lines) Patch
M runtime/vm/isolate_reload_test.cc View 1 chunk +98 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
I'm surprised these already pass. It suggests the mirrors issue is more subtle and less ...
4 years, 5 months ago (2016-07-20 17:41:12 UTC) #2
Cutch
lgtm
4 years, 5 months ago (2016-07-20 17:44:17 UTC) #3
rmacnak
4 years, 5 months ago (2016-07-20 19:34:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8e7e84811245379f305f3e287caded936b30ddd5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698