Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2160953004: [Chromecast] Pass security origin to CastCdm and remove destination url (Closed)

Created:
4 years, 5 months ago by yucliu1
Modified:
4 years, 4 months ago
Reviewers:
halliwell, ryanchung
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, eme-reviews_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Pass security origin to CastCdm and remove destination url 1. Pass security origin when creating CastCdm. 2. Remove destination url in media session message callback, as unprefixed eme doesn't need it. BUG=internal b/30075657 TEST=Mpl End2End test. Committed: https://crrev.com/21bf060fb14a810fedb81de116a08f3138caffb7 Cr-Commit-Position: refs/heads/master@{#407522}

Patch Set 1 #

Patch Set 2 : Depends on //url:url #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chromecast/browser/media/cast_browser_cdm_factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M chromecast/browser/media/cast_browser_cdm_factory.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chromecast/media/cdm/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/media/cdm/cast_cdm.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/media/cdm/cast_cdm.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
yucliu1
4 years, 5 months ago (2016-07-20 23:06:26 UTC) #3
halliwell
On 2016/07/20 23:06:26, yucliu1 wrote: lgtm
4 years, 5 months ago (2016-07-20 23:25:40 UTC) #4
ryanchung
lgtm
4 years, 5 months ago (2016-07-20 23:54:19 UTC) #5
yucliu1
Add "//url:url" to make CQ happy.
4 years, 5 months ago (2016-07-21 00:26:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160953004/20001
4 years, 5 months ago (2016-07-22 17:45:34 UTC) #10
yucliu1
Modify BUILD.gn after l-g-t-m. Please take a look.
4 years, 5 months ago (2016-07-22 17:46:36 UTC) #11
ryanchung
On 2016/07/22 17:46:36, yucliu1 wrote: > Modify BUILD.gn after l-g-t-m. Please take a look. Do ...
4 years, 5 months ago (2016-07-22 17:49:22 UTC) #12
yucliu1
On 2016/07/22 17:49:22, ryanchung wrote: > On 2016/07/22 17:46:36, yucliu1 wrote: > > Modify BUILD.gn ...
4 years, 5 months ago (2016-07-22 19:08:32 UTC) #13
halliwell
On 2016/07/22 19:08:32, yucliu1 wrote: > On 2016/07/22 17:49:22, ryanchung wrote: > > On 2016/07/22 ...
4 years, 5 months ago (2016-07-25 17:28:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160953004/20001
4 years, 5 months ago (2016-07-25 17:29:20 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-25 18:29:50 UTC) #18
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/21bf060fb14a810fedb81de116a08f3138caffb7 Cr-Commit-Position: refs/heads/master@{#407522}
4 years, 5 months ago (2016-07-25 18:31:12 UTC) #20
yucliu1
4 years, 4 months ago (2016-08-02 22:35:30 UTC) #21
Message was sent while issue was closed.
On 2016/07/25 18:31:12, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/21bf060fb14a810fedb81de116a08f3138caffb7
> Cr-Commit-Position: refs/heads/master@{#407522}

PS3 is uploaded by mistake. Please ignore.

Powered by Google App Engine
This is Rietveld 408576698