telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend_unittest.py - Issue 2160953003: [Telemetry][Tracing] Split StopTracing and CollectTraceData for Chrome Tracing Agent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend_unittest.py

Issue 2160953003: [Telemetry][Tracing] Split StopTracing and CollectTraceData for Chrome Tracing Agent. (Closed) Base URL: git@github.com:catapult-project/catapult@master

Patch Set: [Telemetry][Tracing] Split StopTracing and CollectTraceData for Chrome Tracing Agent. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py ('k') | telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend_unittest.py

diff --git a/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend_unittest.py b/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend_unittest.py

index 7efe1fdad829742f28f324487b7b5f37dd9c2145..635a7c43b75141d7f591db1546843abce23626ee 100644

--- a/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend_unittest.py

+++ b/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend_unittest.py

@@ -88,5 +88,6 @@ class DevToolsClientBackendTest(browser_test_case.BrowserTestCase):

# Stop Chrome tracing and check that the resulting data is valid.

builder = trace_data.TraceDataBuilder()

- devtools_client.StopChromeTracing(builder)

+ devtools_client.StopChromeTracing()

+ devtools_client.CollectChromeTracingData(builder)

model.TimelineModel(builder.AsData())