telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py - Issue 2160953003: [Telemetry][Tracing] Split StopTracing and CollectTraceData for Chrome Tracing Agent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

Issue 2160953003: [Telemetry][Tracing] Split StopTracing and CollectTraceData for Chrome Tracing Agent. (Closed) Base URL: git@github.com:catapult-project/catapult@master

Patch Set: [Telemetry][Tracing] Split StopTracing and CollectTraceData for Chrome Tracing Agent. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/backends/browser_backend.py ('k') | telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

diff --git a/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py b/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

index 317c9007bb3eba80b553048511f0fe91cb177a8d..b215ea73cf27bc4d19f96ee31271f16a73bc2cbb 100644

--- a/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

+++ b/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

@@ -249,8 +249,11 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):

"""

return self.devtools_client.StartChromeTracing(trace_options, timeout)

- def StopTracing(self, trace_data_builder):

- self.devtools_client.StopChromeTracing(trace_data_builder)

+ def StopTracing(self):

+ self.devtools_client.StopChromeTracing()

+ def CollectTracingData(self, trace_data_builder):

+ self.devtools_client.CollectChromeTracingData(trace_data_builder)

def GetProcessName(self, cmd_line):

"""Returns a user-friendly name for the process of the given |cmd_line|."""