Use CSSTokenizerInputStream::peekWithoutReplacement instead of peek().

Use CSSTokenizerInputStream::peekWithoutReplacement instead of peek().

nextInputChar() is the only caller of peek() that wants NUL replacement,
lets have all other callers use peekWithoutReplacement and skip a branch
instead.

This leaves only nextInputChar() calling peek(0) which lets us merge peek
into nextInputChar and since the lookaheadOffset is always 0 we can also
simplify the code.

BUG=605792
Committed: https://crrev.com/a11575f6ecbe2f649a64f6727382f80a9c4c9880
Cr-Commit-Position: refs/heads/master@{#406465}

[esprehn, 2016-07-19 01:19:34]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 01:20:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 02:41:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 02:41:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[esprehn, 2016-07-19 06:25:57]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 06:26:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-07-19 06:43:40]

Description was changed from

==========
peekWithoutReplacement.

BUG=
==========

to

==========
Replace all callers of CSSTokenizerInputStream::peek with
peekWithoutReplacement.

All callers of peek() that aren't nextInputChar() don't actually want NUL
replacement, lets have them call peekWithoutReplacement and skip a branch
instead. This leaves only nextInputChar() calling peek(0) which lets us
merge peek into nextInputChar and since the lookaheadOffset is always 0
we can simplify the code.

BUG=605792
==========

[esprehn, 2016-07-19 07:00:44]

Description was changed from

==========
Replace all callers of CSSTokenizerInputStream::peek with
peekWithoutReplacement.

All callers of peek() that aren't nextInputChar() don't actually want NUL
replacement, lets have them call peekWithoutReplacement and skip a branch
instead. This leaves only nextInputChar() calling peek(0) which lets us
merge peek into nextInputChar and since the lookaheadOffset is always 0
we can simplify the code.

BUG=605792
==========

to

==========
Use CSSTokenizerInputStream::peekWithoutReplacement instead of peek().

nextInputChar() is the only caller of peek() that wants NUL replacement,
lets have all other callers use peekWithoutReplacement and skip a branch
instead.

This leaves only nextInputChar() calling peek(0) which lets us merge peek
into nextInputChar, and since the lookaheadOffset is always 0 we can also
simplify the code.

BUG=605792
==========

[esprehn, 2016-07-19 07:11:32]

Description was changed from

==========
Use CSSTokenizerInputStream::peekWithoutReplacement instead of peek().

nextInputChar() is the only caller of peek() that wants NUL replacement,
lets have all other callers use peekWithoutReplacement and skip a branch
instead.

This leaves only nextInputChar() calling peek(0) which lets us merge peek
into nextInputChar, and since the lookaheadOffset is always 0 we can also
simplify the code.

BUG=605792
==========

to

==========
Use CSSTokenizerInputStream::peekWithoutReplacement instead of peek().

nextInputChar() is the only caller of peek() that wants NUL replacement,
lets have all other callers use peekWithoutReplacement and skip a branch
instead.

This leaves only nextInputChar() calling peek(0) which lets us merge peek
into nextInputChar and since the lookaheadOffset is always 0 we can also
simplify the code.

BUG=605792
==========

[esprehn, 2016-07-19 07:12:13]

esprehn@chromium.org changed reviewers:
+ meade@chromium.org, timloh@chromium.org

[commit-bot: I haz the power, 2016-07-19 07:51:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 07:51:06]

Dry run: This issue passed the CQ dry run.

[esprehn, 2016-07-20 00:40:41]

ping :)

[Timothy Loh, 2016-07-20 02:05:28]

On 2016/07/20 00:40:41, esprehn wrote:
> ping :)

lgtm

[esprehn, 2016-07-20 02:15:16]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-07-20 02:15:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 02:20:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-20 02:22:53]

Description was changed from

==========
Use CSSTokenizerInputStream::peekWithoutReplacement instead of peek().

nextInputChar() is the only caller of peek() that wants NUL replacement,
lets have all other callers use peekWithoutReplacement and skip a branch
instead.

This leaves only nextInputChar() calling peek(0) which lets us merge peek
into nextInputChar and since the lookaheadOffset is always 0 we can also
simplify the code.

BUG=605792
==========

to

==========
Use CSSTokenizerInputStream::peekWithoutReplacement instead of peek().

nextInputChar() is the only caller of peek() that wants NUL replacement,
lets have all other callers use peekWithoutReplacement and skip a branch
instead.

This leaves only nextInputChar() calling peek(0) which lets us merge peek
into nextInputChar and since the lookaheadOffset is always 0 we can also
simplify the code.

BUG=605792

Committed: https://crrev.com/a11575f6ecbe2f649a64f6727382f80a9c4c9880
Cr-Commit-Position: refs/heads/master@{#406465}
==========

[commit-bot: I haz the power, 2016-07-20 02:22:54]

Patchset 2 (id:??) landed as
https://crrev.com/a11575f6ecbe2f649a64f6727382f80a9c4c9880
Cr-Commit-Position: refs/heads/master@{#406465}