Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: appengine/cr-buildbucket/proto/project_config.proto

Issue 2160913003: swarmbucket: fix empty dimension value (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: add swarmbucketbuilders test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/cr-buildbucket/swarming/swarming.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/cr-buildbucket/proto/project_config.proto
diff --git a/appengine/cr-buildbucket/proto/project_config.proto b/appengine/cr-buildbucket/proto/project_config.proto
index 597954b3ddbb584be3489a1a85342eb94dce21c4..f63a0fd48daff6ec1e85fae745f25f251d105119 100644
--- a/appengine/cr-buildbucket/proto/project_config.proto
+++ b/appengine/cr-buildbucket/proto/project_config.proto
@@ -61,6 +61,9 @@ message Swarming {
// "swarming_tag:builder:release"
repeated string swarming_tags = 2;
// Colon-delimited key-value pair of task dimensions.
+ //
+ // If value is not specified ("<key>:"), then it excludes a value for the
+ // same key specified in common_dimensions.
repeated string dimensions = 3;
// Specifies that a recipe to run.
optional Recipe recipe = 4;
@@ -82,6 +85,9 @@ message Swarming {
repeated string common_swarming_tags = 3;
// Colon-delimited key-value pair of common task dimensions.
+ //
+ // If value is not specified ("<key>:"), then it excludes a value for the
+ // same key specified in swarming task template.
repeated string common_dimensions = 4;
// Configuration for each builder.
« no previous file with comments | « no previous file | appengine/cr-buildbucket/swarming/swarming.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698