appengine/cr-buildbucket/swarming/swarming.py - Issue 2160913003: swarmbucket: fix empty dimension value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/cr-buildbucket/swarming/swarming.py

Issue 2160913003: swarmbucket: fix empty dimension value (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/cr-buildbucket/swarming/swarming.py

diff --git a/appengine/cr-buildbucket/swarming/swarming.py b/appengine/cr-buildbucket/swarming/swarming.py

index ef649ea229e31e9098401fd7fa78d8460b632fc7..ab3a8c083a2dca72481dc3be5da2dc1792f84b54 100644

--- a/appengine/cr-buildbucket/swarming/swarming.py

+++ b/appengine/cr-buildbucket/swarming/swarming.py

@@ -302,7 +302,7 @@ def _prepare_dimensions(global_dims, bucket_cfg_dims, builder_cfg_dims):

merged = {}

for ds in (global_dims, bucket_dims, builder_dims):

merged.update(ds)

- return sorted({'key': k, 'value': v} for k, v in merged.iteritems())

+ return sorted({'key': k, 'value': v} for k, v in merged.iteritems() if v)

@ndb.tasklet