Set enable_google_now to false

Set enable_google_now to false

This prepares the existing Google Now code for cleanup.

BUG=539674
Committed: https://crrev.com/6078fb77ef897bd37973a6eb08a6f34c55665abf
Cr-Commit-Position: refs/heads/master@{#406188}

[robliao, 2016-07-18 22:21:49]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[robliao, 2016-07-18 22:22:06]

Description was changed from

==========
Set enable_google_now to false

This prepares the existing Google Now code for cleanup.

BUG=539674
==========

to

==========
Set enable_google_now to false

This prepares the existing Google Now code for cleanup.

BUG=539674
==========

[robliao, 2016-07-18 22:22:06]

robliao@chromium.org changed reviewers:
+ skare@chromium.org

[commit-bot: I haz the power, 2016-07-18 22:23:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 22:27:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 22:27:26]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[robliao, 2016-07-18 22:32:00]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[robliao, 2016-07-18 22:32:27]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-07-18 22:32:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 22:36:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 22:36:30]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[robliao, 2016-07-18 22:40:07]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 22:40:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skare_, 2016-07-18 22:55:55]

lgtm

future reviewers: this component extension hasn't loaded for end users for a
while; the few KB of javascript and icon included for the extension are dead
code; this should prevent their inclusion, and then we have a followup CL to
remove the extension content from the repo.

Then there is removing histograms, items that check the enable_google_now flag,
and then the flag itself.

Thanks!

[robliao, 2016-07-18 23:31:27]

robliao@chromium.org changed reviewers:
+ thestig@chromium.org

[robliao, 2016-07-18 23:31:27]

thestig@chromium.org: Please review this CL. Thanks!

[Lei Zhang, 2016-07-18 23:40:45]

lgtm

Well, this solves my complaint about the extra process at start up.

[robliao, 2016-07-18 23:48:49]

On 2016/07/18 23:40:45, Lei Zhang wrote:
> lgtm
> 
> Well, this solves my complaint about the extra process at start up.

Indeed, although that happened sooner when it was turned off via variations.

[commit-bot: I haz the power, 2016-07-19 00:05:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 00:05:50]

Dry run: This issue passed the CQ dry run.

[robliao, 2016-07-19 00:09:06]

The CQ bit was checked by robliao@chromium.org

[commit-bot: I haz the power, 2016-07-19 00:09:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 00:20:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 00:20:04]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[robliao, 2016-07-19 00:22:11]

The CQ bit was unchecked by robliao@chromium.org

[robliao, 2016-07-19 00:22:51]

The CQ bit was checked by robliao@chromium.org

[robliao, 2016-07-19 00:22:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, skare@chromium.org
Link to the patchset: https://codereview.chromium.org/2160853002/#ps60001
(title: "Sync to d5293c9 and Resolve Conflicts")

[commit-bot: I haz the power, 2016-07-19 00:23:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 02:09:30]

Description was changed from

==========
Set enable_google_now to false

This prepares the existing Google Now code for cleanup.

BUG=539674
==========

to

==========
Set enable_google_now to false

This prepares the existing Google Now code for cleanup.

BUG=539674
==========

[commit-bot: I haz the power, 2016-07-19 02:09:32]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-07-19 02:12:07]

Description was changed from

==========
Set enable_google_now to false

This prepares the existing Google Now code for cleanup.

BUG=539674
==========

to

==========
Set enable_google_now to false

This prepares the existing Google Now code for cleanup.

BUG=539674

Committed: https://crrev.com/6078fb77ef897bd37973a6eb08a6f34c55665abf
Cr-Commit-Position: refs/heads/master@{#406188}
==========

[commit-bot: I haz the power, 2016-07-19 02:12:10]

Patchset 3 (id:??) landed as
https://crrev.com/6078fb77ef897bd37973a6eb08a6f34c55665abf
Cr-Commit-Position: refs/heads/master@{#406188}