Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2160843002: [DevTools] Introduce DOM capability. (Closed)

Created:
4 years, 5 months ago by dgozman
Modified:
4 years, 5 months ago
Reviewers:
eostroukhov-old
CC:
chromium-reviews, caseq+blink_chromium.org, shans, rjwright, blink-reviews-animation_chromium.org, darktears, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, Eric Willigers, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Introduce DOM capability. Used for DOM, CSS, Animation, LayerTree. Not supported by ServiceWorker targets. BUG=none Committed: https://crrev.com/48661fbb13fcf93720cf21927ce1376ab9f861ba Cr-Commit-Position: refs/heads/master@{#406219}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -14 lines) Patch
M third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/EventListenersUtils.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/Spectrum.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Target.js View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline_model/LayerTreeModel.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
dgozman
Take a look please.
4 years, 5 months ago (2016-07-18 22:12:08 UTC) #2
eostroukhov-old
lgtm
4 years, 5 months ago (2016-07-18 22:15:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160843002/1
4 years, 5 months ago (2016-07-18 22:39:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/105958)
4 years, 5 months ago (2016-07-19 00:01:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160843002/1
4 years, 5 months ago (2016-07-19 00:09:54 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/257805)
4 years, 5 months ago (2016-07-19 03:44:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160843002/1
4 years, 5 months ago (2016-07-19 04:07:23 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 05:42:22 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 05:44:10 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48661fbb13fcf93720cf21927ce1376ab9f861ba
Cr-Commit-Position: refs/heads/master@{#406219}

Powered by Google App Engine
This is Rietveld 408576698