ash/metrics/user_metrics_recorder.cc - Issue 2160833002: Adds WmShell::RecordTaskSwitchMetric()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/metrics/user_metrics_recorder.cc

Issue 2160833002: Adds WmShell::RecordTaskSwitchMetric() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/metrics/user_metrics_recorder.cc

diff --git a/ash/metrics/user_metrics_recorder.cc b/ash/metrics/user_metrics_recorder.cc

index 7fe5858848e33bc13ceb6852ac79f484417559d1..781f8b465f687b492b1e681039cdb8d494076353 100644

--- a/ash/metrics/user_metrics_recorder.cc

+++ b/ash/metrics/user_metrics_recorder.cc

@@ -238,8 +238,7 @@ void UserMetricsRecorder::RecordUserMetricsAction(UserMetricsAction action) {

break;

case UMA_DESKTOP_SWITCH_TASK:

RecordAction(UserMetricsAction("Desktop_SwitchTask"));

- task_switch_metrics_recorder_.OnTaskSwitch(

- TaskSwitchMetricsRecorder::DESKTOP);

+ task_switch_metrics_recorder_.OnTaskSwitch(TaskSwitchSource::DESKTOP);

break;

case UMA_DRAG_MAXIMIZE_LEFT:

RecordAction(UserMetricsAction("WindowDrag_MaximizeLeft"));

@@ -261,16 +260,14 @@ void UserMetricsRecorder::RecordUserMetricsAction(UserMetricsAction action) {

break;

case UMA_LAUNCHER_LAUNCH_TASK:

RecordAction(UserMetricsAction("Launcher_LaunchTask"));

- task_switch_metrics_recorder_.OnTaskSwitch(

- TaskSwitchMetricsRecorder::SHELF);

+ task_switch_metrics_recorder_.OnTaskSwitch(TaskSwitchSource::SHELF);

break;

case UMA_LAUNCHER_MINIMIZE_TASK:

RecordAction(UserMetricsAction("Launcher_MinimizeTask"));

break;

case UMA_LAUNCHER_SWITCH_TASK:

RecordAction(UserMetricsAction("Launcher_SwitchTask"));

- task_switch_metrics_recorder_.OnTaskSwitch(

- TaskSwitchMetricsRecorder::SHELF);

+ task_switch_metrics_recorder_.OnTaskSwitch(TaskSwitchSource::SHELF);

break;

case UMA_MAXIMIZE_MODE_DISABLED:

RecordAction(UserMetricsAction("Touchview_Disabled"));

@@ -568,7 +565,7 @@ void UserMetricsRecorder::RecordUserMetricsAction(UserMetricsAction action) {

case UMA_WINDOW_OVERVIEW_ACTIVE_WINDOW_CHANGED:

RecordAction(UserMetricsAction("WindowSelector_ActiveWindowChanged"));

task_switch_metrics_recorder_.OnTaskSwitch(

- TaskSwitchMetricsRecorder::OVERVIEW_MODE);

+ TaskSwitchSource::OVERVIEW_MODE);

break;

case UMA_WINDOW_OVERVIEW_ENTER_KEY:

RecordAction(UserMetricsAction("WindowSelector_OverviewEnterKey"));

« no previous file with comments | « ash/metrics/task_switch_metrics_recorder_unittest.cc ('k') | ash/mus/bridge/wm_shell_mus.h » ('j') | no next file with comments »