Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2160833002: Adds WmShell::RecordTaskSwitchMetric() (Closed)

Created:
4 years, 5 months ago by sky
Modified:
4 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, Matt Giuca, tapted, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds WmShell::RecordTaskSwitchMetric() And wires up in WindowCycleController. BUG=582590 TEST=covered by tests R=jamescook@chromium.org Committed: https://crrev.com/5c14b20daaa4f88aefa0ee121dbc8e41bf28c917 Cr-Commit-Position: refs/heads/master@{#406207}

Patch Set 1 #

Total comments: 3

Patch Set 2 : comment #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -84 lines) Patch
M ash/aura/wm_shell_aura.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ash/aura/wm_shell_aura.cc View 1 2 2 chunks +7 lines, -1 line 0 comments Download
A ash/common/metrics/task_switch_source.h View 1 1 chunk +34 lines, -0 lines 0 comments Download
M ash/common/wm_shell.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M ash/metrics/task_switch_metrics_recorder.h View 2 chunks +1 line, -26 lines 0 comments Download
M ash/metrics/task_switch_metrics_recorder.cc View 3 chunks +15 lines, -15 lines 0 comments Download
M ash/metrics/task_switch_metrics_recorder_unittest.cc View 3 chunks +28 lines, -29 lines 0 comments Download
M ash/metrics/user_metrics_recorder.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M ash/wm/window_cycle_controller.cc View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_controller_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/metrics/chrome_user_metrics_recorder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
sky
4 years, 5 months ago (2016-07-18 22:06:53 UTC) #1
James Cook
LGTM https://codereview.chromium.org/2160833002/diff/1/ash/common/metrics/task_switch_source.h File ash/common/metrics/task_switch_source.h (right): https://codereview.chromium.org/2160833002/diff/1/ash/common/metrics/task_switch_source.h#newcode14 ash/common/metrics/task_switch_source.h:14: // should NOT be used outside of this ...
4 years, 5 months ago (2016-07-18 22:27:10 UTC) #4
sky
https://codereview.chromium.org/2160833002/diff/1/ash/common/metrics/task_switch_source.h File ash/common/metrics/task_switch_source.h (right): https://codereview.chromium.org/2160833002/diff/1/ash/common/metrics/task_switch_source.h#newcode14 ash/common/metrics/task_switch_source.h:14: // should NOT be used outside of this class. ...
4 years, 5 months ago (2016-07-18 22:43:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160833002/40001
4 years, 5 months ago (2016-07-19 03:01:40 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-19 03:44:00 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 03:44:05 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 03:46:16 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/5c14b20daaa4f88aefa0ee121dbc8e41bf28c917
Cr-Commit-Position: refs/heads/master@{#406207}

Powered by Google App Engine
This is Rietveld 408576698