Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2160793004: Converted Observatory curly-block element (Closed)

Created:
4 years, 5 months ago by cbernaschina
Modified:
4 years, 5 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added missing reference in observatory_sources.gypi #

Patch Set 3 : Converted from single to triple quotes #

Patch Set 4 : Marged with master #

Patch Set 5 : Added missing binder callback registration #

Patch Set 6 : Converted to checkAndReact helper #

Patch Set 7 : Fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+370 lines, -91 lines) Patch
M runtime/observatory/lib/elements.dart View 1 2 3 4 4 chunks +5 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/class_ref.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/class_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/context_ref.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/curly_block.dart View 1 2 3 4 5 6 1 chunk +86 lines, -34 lines 0 comments Download
D runtime/observatory/lib/src/elements/curly_block.html View 1 chunk +0 lines, -44 lines 0 comments Download
A runtime/observatory/lib/src/elements/curly_block_wrapper.dart View 1 2 3 4 1 chunk +100 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/error_ref.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/inbound_reference.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/instance_ref.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/isolate_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/library_ref.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/library_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/objectstore_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/vm_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A runtime/observatory/tests/observatory_ui/curly_block/element_test.dart View 1 2 3 4 5 6 1 chunk +179 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/curly_block/element_test.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
cbernaschina
4 years, 5 months ago (2016-07-19 15:56:37 UTC) #1
Cutch
LGTM w/c https://codereview.chromium.org/2160793004/diff/1/runtime/observatory/lib/src/elements/curly_block.dart File runtime/observatory/lib/src/elements/curly_block.dart (right): https://codereview.chromium.org/2160793004/diff/1/runtime/observatory/lib/src/elements/curly_block.dart#newcode21 runtime/observatory/lib/src/elements/curly_block.dart:21: style.text = 'span.curly-block {' use ''' quotes ...
4 years, 5 months ago (2016-07-19 16:18:56 UTC) #3
cbernaschina
https://codereview.chromium.org/2160793004/diff/1/runtime/observatory/lib/src/elements/curly_block.dart File runtime/observatory/lib/src/elements/curly_block.dart (right): https://codereview.chromium.org/2160793004/diff/1/runtime/observatory/lib/src/elements/curly_block.dart#newcode21 runtime/observatory/lib/src/elements/curly_block.dart:21: style.text = 'span.curly-block {' On 2016/07/19 16:18:56, Cutch wrote: ...
4 years, 5 months ago (2016-07-19 16:36:01 UTC) #4
cbernaschina
4 years, 5 months ago (2016-07-19 18:33:10 UTC) #5
rmacnak
Breaks some uses of curly blocks. If I expand a ref to a non-empty list, ...
4 years, 5 months ago (2016-07-19 22:02:43 UTC) #6
cbernaschina
Fixed. It was missing: binder.registerCallback(this);
4 years, 5 months ago (2016-07-20 00:19:01 UTC) #7
cbernaschina
4 years, 5 months ago (2016-07-20 19:57:28 UTC) #8
rmacnak
lgtm
4 years, 5 months ago (2016-07-21 23:20:50 UTC) #9
cbernaschina
4 years, 5 months ago (2016-07-21 23:42:35 UTC) #10
cbernaschina
4 years, 5 months ago (2016-07-21 23:42:55 UTC) #12
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) manually as
a459125aa121af987c20cb725021b42943a2a02b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698