telemetry/telemetry/timeline/trace_data_unittest.py - Issue 2160793003: Support traces containing all parts/agents returned via DevTools streams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/timeline/trace_data_unittest.py

Issue 2160793003: Support traces containing all parts/agents returned via DevTools streams (Closed) Base URL: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master

Patch Set: dropped _had_data_collected Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py ('K') | « telemetry/telemetry/timeline/trace_data.py ('k') | telemetry/telemetry/timeline/trace_event_importer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/timeline/trace_data_unittest.py

diff --git a/telemetry/telemetry/timeline/trace_data_unittest.py b/telemetry/telemetry/timeline/trace_data_unittest.py

index 943d1d60222add30e5a619a58c6e54769da4ea0b..89f6c68795c3bed27fe870bbc447b653b7e03604 100644

--- a/telemetry/telemetry/timeline/trace_data_unittest.py

+++ b/telemetry/telemetry/timeline/trace_data_unittest.py

@@ -65,12 +65,14 @@ class TraceDataTest(unittest.TestCase):

def testListForm(self):

d = trace_data.TraceData([{'ph': 'B'}])

self.assertTrue(d.HasTraceFor(trace_data.CHROME_TRACE_PART))

- self.assertEquals(1, len(d.GetTraceFor(trace_data.CHROME_TRACE_PART)))

+ events = d.GetTraceFor(trace_data.CHROME_TRACE_PART).get('traceEvents', [])

+ self.assertEquals(1, len(events))

def testStringForm(self):

d = trace_data.TraceData('[{"ph": "B"}]')

self.assertTrue(d.HasTraceFor(trace_data.CHROME_TRACE_PART))

- self.assertEquals(1, len(d.GetTraceFor(trace_data.CHROME_TRACE_PART)))

+ events = d.GetTraceFor(trace_data.CHROME_TRACE_PART).get('traceEvents', [])

+ self.assertEquals(1, len(events))

def testStringForm2(self):

d = trace_data.TraceData('{"inspectorTimelineEvents": [1]}')