Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2160783002:
Exclude flaky test on DrMemory (Closed)
|
Created:
4 years, 5 months ago by Irfan Modified:
4 years, 5 months ago Reviewers:
Lei Zhang CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionExclude flaky test on DrMemory
TBR=thestig@chromium.org
BUG=629167
Committed: https://crrev.com/ad440f02c69a7e7ef7efb0129d881a445ca2e8d6
Cr-Commit-Position: refs/heads/master@{#406113}
Patch Set 1 #Patch Set 2 : Disable flaky test on DrMemory #Messages
Total messages: 19 (9 generated)
Description was changed from ========== Suppress UNADDRESSABLE ACCESS in DrawLayersOnThread BUG=629167 ========== to ========== Suppress UNADDRESSABLE ACCESS in DrawLayersOnThread BUG=629167 ==========
isheriff@chromium.org changed reviewers: + thestig@chromium.org
Lei, can you please check if I have added suppressions right. Am still a bit jet-lagged after moving zones :)
UNADDRESSABLE ACCESS: reading 0x00000008-0x0000000c -> it's dereferencing a nullptr. This test needs to be disabled via tools/valgrind/gtest_exclude/cc_unittests.gtest-drmemory_win32.txt instead.
On 2016/07/18 20:19:47, Lei Zhang wrote: > UNADDRESSABLE ACCESS: reading 0x00000008-0x0000000c -> it's dereferencing a > nullptr. This test needs to be disabled via > tools/valgrind/gtest_exclude/cc_unittests.gtest-drmemory_win32.txt instead. That is to say, the test is crashing and subsequent test cases aren't running.
Description was changed from
==========
Suppress UNADDRESSABLE ACCESS in DrawLayersOnThread
BUG=629167
==========
to
==========
Exclude flaky test on DrMemory
TBR=thestig@chromium.org
BUG=629167
==========
The CQ bit was checked by isheriff@chromium.org to run a CQ dry run
lgtm
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by isheriff@chromium.org
The CQ bit was checked by isheriff@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from
==========
Exclude flaky test on DrMemory
TBR=thestig@chromium.org
BUG=629167
==========
to
==========
Exclude flaky test on DrMemory
TBR=thestig@chromium.org
BUG=629167
==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from
==========
Exclude flaky test on DrMemory
TBR=thestig@chromium.org
BUG=629167
==========
to
==========
Exclude flaky test on DrMemory
TBR=thestig@chromium.org
BUG=629167
Committed: https://crrev.com/ad440f02c69a7e7ef7efb0129d881a445ca2e8d6
Cr-Commit-Position: refs/heads/master@{#406113}
==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ad440f02c69a7e7ef7efb0129d881a445ca2e8d6 Cr-Commit-Position: refs/heads/master@{#406113}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2165463002/ by danakj@chromium.org. The reason for reverting is: Test should be fixed, this is no longer needed.. |
