Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2160753002: Add myself as OWNER of content/browser/find_request_manager*. (Closed)

Created:
4 years, 5 months ago by paulmeyer
Modified:
4 years, 5 months ago
Reviewers:
ncarter (slow), *nasko
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This patch adds me as an OWNER of content/browser/find_request_manager*. Committed: https://crrev.com/9703cc9e5458725c41a78a28fe13807290141b5e Cr-Commit-Position: refs/heads/master@{#406625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
paulmeyer
4 years, 5 months ago (2016-07-18 19:30:23 UTC) #3
ncarter (slow)
lgtm. Nasko, is this a good way to structure ownership of find-in-page?
4 years, 5 months ago (2016-07-18 20:07:40 UTC) #6
nasko
On 2016/07/18 20:07:40, ncarter wrote: > lgtm. Nasko, is this a good way to structure ...
4 years, 5 months ago (2016-07-18 20:32:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160753002/1
4 years, 5 months ago (2016-07-19 13:27:16 UTC) #9
commit-bot: I haz the power
All required reviewers (with asterisk prefixes) have not yet approved this CL. No L-G-T-M from ...
4 years, 5 months ago (2016-07-19 13:27:17 UTC) #11
nasko
LGTM
4 years, 5 months ago (2016-07-20 16:45:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160753002/1
4 years, 5 months ago (2016-07-20 17:50:22 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 18:37:19 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 18:42:58 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9703cc9e5458725c41a78a28fe13807290141b5e
Cr-Commit-Position: refs/heads/master@{#406625}

Powered by Google App Engine
This is Rietveld 408576698