Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 216073002: Mojo: Split off the C++ parts of mojo/public/c/system macros.h to their own file. (Closed)

Created:
6 years, 9 months ago by viettrungluu
Modified:
6 years, 9 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Split off the C++ parts of mojo/public/c/system macros.h to their own file. (Also split the tests.) R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260114

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -261 lines) Patch
M mojo/apps/js/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/aura_demo/aura_demo.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/examples/compositor_app/compositor_app.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/examples/launcher/launcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/examples/sample_app/sample_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/examples/view_manager/view_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/mojo_public.gypi View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/public/bindings/allocation_scope.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/fixed_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/message_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/scratch_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/remote_ptr.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/tests/connector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/tests/router_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/system/macros.h View 1 chunk +3 lines, -47 lines 0 comments Download
M mojo/public/c/tests/system/core_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
A mojo/public/c/tests/system/macros_unittest.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M mojo/public/cpp/system/core.h View 1 chunk +1 line, -1 line 0 comments Download
A mojo/public/cpp/system/macros.h View 1 chunk +53 lines, -0 lines 0 comments Download
M mojo/public/cpp/tests/system/core_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/cpp/tests/system/macros_unittest.cc View 5 chunks +10 lines, -33 lines 0 comments Download
M mojo/public/environment/environment.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/environment/tests/async_waiter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/public/tests/system/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/public/tests/system/macros_unittest.cc View 1 chunk +0 lines, -148 lines 0 comments Download
M mojo/public/utility/lib/thread_local.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/utility/mutex.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/utility/tests/mutex_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/utility/tests/thread_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/utility/thread.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
viettrungluu
6 years, 9 months ago (2014-03-28 02:00:46 UTC) #1
darin (slow to review)
LGTM
6 years, 9 months ago (2014-03-28 05:37:40 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-28 13:09:20 UTC) #3
viettrungluu
The CQ bit was unchecked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-28 13:09:29 UTC) #4
viettrungluu
6 years, 9 months ago (2014-03-28 13:23:28 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r260114 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698