Issue 2160723002: Validate the regex used in search.findTopLevelDeclarations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2160723002: Validate the regex used in search.findTopLevelDeclarations. (Closed)

Created:
4 years, 5 months ago by devoncarew

Modified:
4 years, 5 months ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
	M	pkg/analysis_server/lib/src/search/search_domain.dart	View		1 chunk	+9 lines, -0 lines	0 comments	Download
	M	pkg/analysis_server/test/search/top_level_declarations_test.dart	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

devoncarew

Redux of https://codereview.chromium.org/2149853002/, to work around a corrupted git client.

4 years, 5 months ago (2016-07-18 19:02:06 UTC) #2

devoncarew

4 years, 5 months ago (2016-07-18 19:13:17 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c52843e42d73e89b3af159bd7f121bbcae5cb96b (presubmit successful).