MD Settings: refactor some main page properties, fix Advanced toggle

chrome/browser/resources/settings/settings_main/settings_main.html

 <link rel="import" href="chrome://resources/cr_elements/icons.html">
 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/html/promise_resolver.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html">
 <link rel="import" href="/about_page/about_page.html">
 <link rel="import" href="/advanced_page/advanced_page.html">
 <link rel="import" href="/basic_page/basic_page.html">
 <link rel="import" href="/settings_main/settings_main_rendered.html">
 <link rel="import" href="/settings_page/main_page_behavior.html">
 <link rel="import" href="/settings_root_css.html">
@@ skipping 20 matching lines @@
 
       #toggleSpacer {
         padding-top: 33px;  /* Part of a 48px spacer (33px + 12px + 3px). */
       }
 
       iron-icon {
         -webkit-margin-start: 16px;
       }
     </style>
     <content select="paper-icon-button"></content>
-    <template is="dom-if" if="[[showBasicPage_]]">
-      <settings-basic-page prefs="{{prefs}}" current-route="{{currentRoute}}">
-      </settings-basic-page>
-    </template>
-    <template is="dom-if" if="[[showAdvancedToggle_]]">
-      <div id="toggleSpacer"></div>
-      <div id="toggleContainer">
-        <div id="advancedToggle" on-tap="toggleAdvancedPage_">
-          <span>$i18n{advancedPageTitle}</span>
-          <iron-icon icon="[[arrowState_(showAdvancedPage_)]]"></iron-icon>
+    <template is="dom-if" if="[[!showPages_.ABOUT]]">

[dschuyler, 2016/07/21 02:38:22]

Why is about all caps, as if it were a const?

[michaelpg, 2016/07/21 03:00:28]

Hmm, I guess it's not a const (since yeah, it's a bool that changes). It's the
keys that are constant.

So you're right, showPages_ is not an @enum, but it's not a @dict or
@unrestricted either (which is what most of our Object properties really are) --
the keys aren't arbitrary. Maybe @struct?

+      <template is="dom-if" if="[[showPages_.BASIC]]">
+        <settings-basic-page prefs="{{prefs}}" current-route="{{currentRoute}}">
+        </settings-basic-page>
+      </template>
+      <div hidden$="[[inSubpage_]]">
+        <div id="toggleSpacer"></div>
+        <div id="toggleContainer">
+          <div id="advancedToggle" on-tap="toggleAdvancedPage_">
+            <span>$i18n{advancedPageTitle}</span>
+            <iron-icon icon="[[arrowState_(showPages_.ADVANCED)]]"></iron-icon>
+          </div>
         </div>
       </div>
+      <template is="dom-if" if="[[showPages_.ADVANCED]]">
+        <settings-advanced-page prefs="{{prefs}}"
+            current-route="{{currentRoute}}">
+        </settings-advanced-page>
+      </template>
     </template>
-    <template is="dom-if" if="[[showAdvancedPage_]]">
-      <settings-advanced-page prefs="{{prefs}}"
-          current-route="{{currentRoute}}">
-      </settings-advanced-page>
-    </template>
-    <template is="dom-if" if="[[showAboutPage_]]">
+    <template is="dom-if" if="[[showPages_.ABOUT]]">
       <settings-about-page current-route="{{currentRoute}}">
       </settings-about-page>
     </template>
   </template>
   <script src="settings_main.js"></script>
   <script src="/search_settings.js"></script>
 </dom-module>