Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2160683002: Break smaller methods out of NewTabPage#initialize which was ~150 lines. (Closed)

Created:
4 years, 5 months ago by Michael van Ouwerkerk
Modified:
4 years, 5 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Break smaller methods out of NewTabPage#initialize which was ~150 lines. BUG=616090 Committed: https://crrev.com/96d9e341ccfaff04bd3f0d6163c47ee17e567485 Cr-Commit-Position: refs/heads/master@{#406237}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -36 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 4 chunks +52 lines, -36 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Michael van Ouwerkerk
Bernhard, could you take a look please?
4 years, 5 months ago (2016-07-18 17:09:48 UTC) #3
Bernhard Bauer
lgtm
4 years, 5 months ago (2016-07-19 08:39:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160683002/1
4 years, 5 months ago (2016-07-19 09:16:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 09:58:38 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 10:00:02 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96d9e341ccfaff04bd3f0d6163c47ee17e567485
Cr-Commit-Position: refs/heads/master@{#406237}

Powered by Google App Engine
This is Rietveld 408576698