Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2160673002: Another fix incremental constants - annotations should use the old unit element. (Closed)

Created:
4 years, 5 months ago by scheglov
Modified:
4 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Another fix incremental constants - annotations should use the old unit element. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/bf19d4147a2757ded34c4dead00a4d5adafacaad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1 line) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/incremental_element_builder.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/incremental_element_builder_test.dart View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 5 months ago (2016-07-18 17:02:43 UTC) #1
Brian Wilkerson
lgtm
4 years, 5 months ago (2016-07-18 17:36:29 UTC) #2
scheglov
4 years, 5 months ago (2016-07-18 17:43:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bf19d4147a2757ded34c4dead00a4d5adafacaad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698