Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Unified Diff: build/config/mac/BUILD.gn

Issue 2160653002: [iOS/GN] Fix generation of .dSYM for fat binary builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/mac/BUILD.gn
diff --git a/build/config/mac/BUILD.gn b/build/config/mac/BUILD.gn
index d49db4383625bb254a07fcca49377c13ce8f2b55..95ed002150fdf3e15d2bf57c3fa59e35d1bf14b4 100644
--- a/build/config/mac/BUILD.gn
+++ b/build/config/mac/BUILD.gn
@@ -3,6 +3,7 @@
# found in the LICENSE file.
import("//build/config/sysroot.gni")
+import("//build/config/ios/ios_sdk.gni")
import("//build/config/mac/mac_sdk.gni")
import("//build/config/mac/symbols.gni")
@@ -103,7 +104,7 @@ config("mac_executable_flags") {
# from a binary, but some targets may wish to specify a saves file to preserve
# specific symbols.
config("strip_all") {
- if (enable_stripping) {
+ if (enable_stripping && (!is_ios || additional_toolchains == [])) {
Robert Sesek 2016/07/18 20:09:42 Considering making |!is_ios || additional_toolchai
sdefresne 2016/07/19 09:12:12 Done.
ldflags = [ "-Wcrl,strip,-x,-S" ]
}
}

Powered by Google App Engine
This is Rietveld 408576698