Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2160643002: [turbofan] ARM64: Tweak code gen for cmp with sxtw (Closed)

Created:
4 years, 5 months ago by martyn.capewell
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] ARM64: Tweak code gen for cmp with sxtw For 64-bit cmp, replace the if clause with InputOperand2_64(), and apply the same change to cmn. BUG= Committed: https://crrev.com/ceb0afbef633a99f007865584570fcb1d4f77b84 Cr-Commit-Position: refs/heads/master@{#37855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
martyn.capewell
4 years, 5 months ago (2016-07-18 15:42:24 UTC) #2
Benedikt Meurer
LGTM, thanks.
4 years, 5 months ago (2016-07-19 04:08:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160643002/1
4 years, 5 months ago (2016-07-19 08:44:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 09:35:10 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 09:35:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ceb0afbef633a99f007865584570fcb1d4f77b84
Cr-Commit-Position: refs/heads/master@{#37855}

Powered by Google App Engine
This is Rietveld 408576698