Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 2160613004: VM: Mark loads from final captured locals immutable. (Closed)

Created:
4 years, 5 months ago by Florian Schneider
Modified:
4 years, 5 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Mark loads from final captured locals immutable. This enables load elimination across calls for these locals. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/37dbf25f13c4e6c71e553d687c4e9ea28e9de38a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
4 years, 5 months ago (2016-07-18 19:51:31 UTC) #2
rmacnak
lgtm
4 years, 5 months ago (2016-07-18 20:31:42 UTC) #3
Florian Schneider
4 years, 5 months ago (2016-07-18 20:33:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
37dbf25f13c4e6c71e553d687c4e9ea28e9de38a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698