Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2160613003:
DevTools: Added empty implementation of navigationRequested method in frontend (Closed)
|
Created:
4 years, 5 months ago by chenwilliam Modified:
4 years, 5 months ago Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: Added empty implementation of navigationRequested method in frontend
This fixes the following Closure compiler error: "property navigationRequested on interface PageAgent.Dispatcher is not implemented by type WebInspector.PageDispatcher" in the file: ~/chromium/src/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:830. The override was missing in crrev.com/2132673002.
We can either leave this implementation empty if it's not needed by DevTools or implement it.
Committed: https://crrev.com/f6e6069bc616d2a7d8e51313abffdfcb41547779
Cr-Commit-Position: refs/heads/master@{#406106}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Address CL feedback #Messages
Total messages: 17 (8 generated)
Description was changed from
==========
DevTools: empty implementation of WebInspector.PageDisPatcher
navigationRequested property to address closure compiler error
BUG=
==========
to
==========
DevTools: empty implementation of WebInspector.PageDispatcher
navigationRequested property to address closure compiler error.
This is a temporary workaround for the following Closure compiler error. We can
either leave this implementation empty if it's not needed by DevTools or
implement it with guidance from alexclarke.
This CL addresses the following Closure compiler error:
Module sdk compile failed: 1 errors
~/chromium/src/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:830:
WARNING - property navigationRequested on interface PageAgent.Dispatcher is not
implemented by type WebInspector.PageDispatcher
WebInspector.PageDispatcher = function(resourceTreeModel)
^
0 error(s), 1 warning(s), 94.5% typed
==========
chenwilliam@chromium.org changed reviewers: + kozyatinskiy@chromium.org
https://codereview.chromium.org/2160613003/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js (right): https://codereview.chromium.org/2160613003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:991: // Empty implementation to address closure compiler error // Frontend is not interested in interstitials.
kozyatinskiy@chromium.org changed reviewers: + lushnikov@chromium.org
Thanks, lgtm. Andrey, we need owner lgtm for frontend, please take a look!
And please make CL title less then 80 characters length, and change description to something like: added empty implementation for networkRequested method on frontend to make compiler happy.
lgtm I also had this patch in CQ, but forgot to put in a comment :) https://codereview.chromium.org/2159863002/
Description was changed from
==========
DevTools: empty implementation of WebInspector.PageDispatcher
navigationRequested property to address closure compiler error.
This is a temporary workaround for the following Closure compiler error. We can
either leave this implementation empty if it's not needed by DevTools or
implement it with guidance from alexclarke.
This CL addresses the following Closure compiler error:
Module sdk compile failed: 1 errors
~/chromium/src/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:830:
WARNING - property navigationRequested on interface PageAgent.Dispatcher is not
implemented by type WebInspector.PageDispatcher
WebInspector.PageDispatcher = function(resourceTreeModel)
^
0 error(s), 1 warning(s), 94.5% typed
==========
to
==========
DevTools: Added empty implementation of navigationRequested method in frontend
This fixes the following Closure compiler error: "property navigationRequested
on interface PageAgent.Dispatcher is not implemented by type
WebInspector.PageDispatcher" in the file:
~/chromium/src/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:830
. We can either leave this implementation empty if it's not needed by DevTools
or implement it.
==========
The CQ bit was checked by chenwilliam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== DevTools: Added empty implementation of navigationRequested method in frontend This fixes the following Closure compiler error: "property navigationRequested on interface PageAgent.Dispatcher is not implemented by type WebInspector.PageDispatcher" in the file: ~/chromium/src/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:830 . We can either leave this implementation empty if it's not needed by DevTools or implement it. ========== to ========== DevTools: Added empty implementation of navigationRequested method in frontend This fixes the following Closure compiler error: "property navigationRequested on interface PageAgent.Dispatcher is not implemented by type WebInspector.PageDispatcher" in the file: ~/chromium/src/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:830. The override was missing in crrev.com/2132673002. We can either leave this implementation empty if it's not needed by DevTools or implement it. ==========
On 2016/07/18 18:45:12, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... Oh interesting, I didn't know this was needed. Thanks for sorting it out.
Message was sent while issue was closed.
Description was changed from ========== DevTools: Added empty implementation of navigationRequested method in frontend This fixes the following Closure compiler error: "property navigationRequested on interface PageAgent.Dispatcher is not implemented by type WebInspector.PageDispatcher" in the file: ~/chromium/src/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:830. The override was missing in crrev.com/2132673002. We can either leave this implementation empty if it's not needed by DevTools or implement it. ========== to ========== DevTools: Added empty implementation of navigationRequested method in frontend This fixes the following Closure compiler error: "property navigationRequested on interface PageAgent.Dispatcher is not implemented by type WebInspector.PageDispatcher" in the file: ~/chromium/src/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:830. The override was missing in crrev.com/2132673002. We can either leave this implementation empty if it's not needed by DevTools or implement it. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== DevTools: Added empty implementation of navigationRequested method in frontend This fixes the following Closure compiler error: "property navigationRequested on interface PageAgent.Dispatcher is not implemented by type WebInspector.PageDispatcher" in the file: ~/chromium/src/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:830. The override was missing in crrev.com/2132673002. We can either leave this implementation empty if it's not needed by DevTools or implement it. ========== to ========== DevTools: Added empty implementation of navigationRequested method in frontend This fixes the following Closure compiler error: "property navigationRequested on interface PageAgent.Dispatcher is not implemented by type WebInspector.PageDispatcher" in the file: ~/chromium/src/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:830. The override was missing in crrev.com/2132673002. We can either leave this implementation empty if it's not needed by DevTools or implement it. Committed: https://crrev.com/f6e6069bc616d2a7d8e51313abffdfcb41547779 Cr-Commit-Position: refs/heads/master@{#406106} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f6e6069bc616d2a7d8e51313abffdfcb41547779 Cr-Commit-Position: refs/heads/master@{#406106} |
